Review main Abandoned

83307[WIP][FEATURE] Add update database schema command

Jochen Roth CR 0 V -1 Hard +328 −0 updated 07/24/25, 15:26

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 6

Review log 45

  1. Jochen Roth uploaded patch set 1 03/07/24, 16:04

  2. core-ci voted on patch set 1 V -1 03/07/24, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54148

  3. Mathias Brodala commented on patch set 1 03/08/24, 08:09

    DatabaseUpdateSchemaCommand.php:43

    This should be an enum.

    DatabaseUpdateSchemaCommand.php:78 Unresolved

    How about "update-types" or "update-actions" instead? The term "names" implies that one can literally select the tables/fields to update.

    DatabaseUpdateSchemaCommand.php:113

    This should not be in the command but extracted instead. The command should be very basic and only call the actual logic. See the existing command of the TYPO3 Console as reference: https://github.com/TYPO3-Console/TYPO3-Console/blob/7916d393fe18b441d0e339fde6c9247fd49a5a58/Classes/Console/Command/Database/DatabaseUpdateSchemaCommand.php
  4. Stefan Bürk commented on patch set 1 03/13/24, 17:22

    DatabaseUpdateSchemaCommand.php:43 Reply Unresolved

    Let's keep that an array for know. We will change this later in v13 along with database analyser refatoring, let's not make that here complex. And the determination method resolving the wildcard may not needed for now. The goal for now is to have one command in as a prepration for some workflow in testing and setups without requiring the TYPO3 console as dependency. Note: Maybe it will become an enum later.

    DatabaseUpdateSchemaCommand.php:113 Reply Unresolved

    General right, but the database analyser working will change in v13 and I literally want to avoid a "additional class" for this extraction for now, and we told Jochen on the community sprint to dense this down to a small footprint, making it not public visible for now. So I'd keep that for now - but with a todo on it stating this.
  5. Jochen Roth abandoned the change 07/24/25, 15:26