83310[TASK] Add tests for copying localized content to non-translated page
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Eric Harrer +1
-
Verified V +2 Done
- Benni Mack +2
- Eric Harrer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 26
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/copyLocalizedContent.csvcopied+5 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/copyLocalizedContentToLocalizedPage.csvcopied+9 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/copyLocalizedContentToNonTranslatedPage.csvcopied+5 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/copyLocalizedContentToPartiallyLocalizedPage.csvcopied+7 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+80 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/DataSet/copyLocalizedContent.csvrenamed+3 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/DataSet/copyLocalizedContentToLocalizedPage.csvcopied+7 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/DataSet/copyLocalizedContentToNonTranslatedPage.csvcopied+3 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/DataSet/copyLocalizedContentToPartiallyLocalizedPage.csvcopied+5 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/ActionTest.php+32 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/copyLocalizedContent.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/copyLocalizedContentToLocalizedPage.csvcopied+12 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/copyLocalizedContentToNonTranslatedPage.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/DataSet/copyLocalizedContentToPartiallyLocalizedPage.csvcopied+10 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/ActionTest.php+124 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/DataSet/copyLocalizedContent.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/DataSet/copyLocalizedContentToLocalizedPage.csvcopied+12 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/DataSet/copyLocalizedContentToNonTranslatedPage.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/DataSet/copyLocalizedContentToPartiallyLocalizedPage.csvcopied+10 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/ActionTest.php+52 −0
Show 6 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/DataSet/copyLocalizedContent.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/DataSet/copyLocalizedContentToLocalizedPage.csvcopied+12 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/DataSet/copyLocalizedContentToNonTranslatedPage.csvcopied+8 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/DataSet/copyLocalizedContentToPartiallyLocalizedPage.csvcopied+10 −4
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/ActionTest.php+92 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php3+28 −2
Review log 3444
Show 1419 earlier messages
-
André Buchmann uploaded patch set 1 03/07/24, 17:08
-
core-ci voted on patch set 1 V -1 03/07/24, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54154
-
André Buchmann uploaded patch set 2
V -103/07/24, 17:20 -
core-ci voted on patch set 2 V +1 03/07/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54157
-
André Buchmann updated the commit message in patch set 3
V +103/08/24, 10:05 -
core-ci voted on patch set 3 V +1 03/08/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54225
-
Benni Mack commented on patch set 3 03/10/24, 23:16
we call it a NonTranslatedPage instead of "NoneTranslatedPage" - apart from that, this looks legit. -
André Buchmann uploaded patch set 4
V +103/20/24, 16:13 -
core-ci voted on patch set 4 V +1 03/20/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54730
-
André Buchmann commented on patch set 4 03/20/24, 16:21
Reply
Thx, changed -
Benni Mack voted on patch set 4 CR +1 V +1 03/20/24, 23:15
-
Christian Kuhn commented on patch set 4 03/20/24, 23:21
wip? -
Christian Kuhn commented on patch set 4 CR -1 03/21/24, 06:45
Reply
great job, but i guess benni upvoted slightly too early here. it would be great if we could extend the patch with the workspace variants. -
Benni Mack commented on patch set 4 CR 0 V 0 03/21/24, 07:11
Reply
argh, it was very late ;) -
André Buchmann marked it work in progress 04/06/24, 08:26
-
André Buchmann uploaded patch set 5
CR -1V +104/28/24, 11:05 -
André Buchmann marked it ready for review 04/28/24, 11:07
-
André Buchmann marked it work in progress 04/28/24, 11:08
-
core-ci voted on patch set 5 V +1 04/28/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56909
-
André Buchmann uploaded patch set 6
V +104/28/24, 12:22 -
core-ci voted on patch set 6 V +1 04/28/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56916
-
André Buchmann uploaded patch set 7
V +104/28/24, 18:39 -
core-ci voted on patch set 7 V +1 04/28/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56928
-
André Buchmann marked it ready for review 04/28/24, 18:49
-
André Buchmann commented on patch set 7 04/28/24, 18:50
Reply
Workspace tests are now added. Please review them :-) -
Oliver Klee updated the commit message in patch set 8
V +104/29/24, 07:34 -
Oliver Klee voted on patch set 8 V +1 04/29/24, 07:34
-
core-ci voted on patch set 8 V +1 04/29/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56955
-
Benni Mack updated the commit message in patch set 9
V +104/29/24, 08:36 -
Benni Mack voted on patch set 9 CR +1 V +1 04/29/24, 08:36
-
core-ci voted on patch set 9 V +1 04/29/24, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56957
-
Oliver Klee voted on patch set 9 V +1 04/29/24, 09:03
-
Oliver Klee commented on patch set 9 04/29/24, 09:06
AbstractActionTestCase.php:143I'm not a big fan of overriding methods and of `parent::*` calls (and also it's not clear from these methods here that they're expected to be overriden in subclasses). Maybe we can have methods with a different name, or have this method call another (empty) method that then gets overriden in the subclasses. That would feel cleaner and more explicit to me. What do you think? -
Christian Kuhn commented on patch set 9 04/29/24, 10:25
AbstractActionTestCase.php:143ReplyThat's how *all* DataScenarios tests are structured at the moment: there is a base implementation in the abstracts without #[Test] that does the main magic, single test cases then extend the abstract class methods, call parent, and have #[Test] attribute. I don't like it too much either, but it's a working approach once you're used to it. I strongly suggest to not deviate from that system with new tests now: If changed, it should be changed globally for all DataScenarios/ tests with a dedicated patch. -
Christian Kuhn commented on patch set 9 04/29/24, 10:29
do you think we should have similar scenarios for pages, too? Copying a page that has translations to a page that has not? pages is a bit special in this case, and i think we'll end up with keeping those pages translations on-copy, while we don't keep them when other table records are copied? -
Oliver Klee commented on patch set 9 04/29/24, 10:30
AbstractActionTestCase.php:143ReplyAck, thanks for the explanation. -
André Buchmann commented on patch set 9 04/29/24, 12:19
Reply
We already have this scenario covered with the `copyPage` tests. They copy the page with uid 89 to 90. 89 has translations to language 1 and 2. The target 90 has no translations. -
Eric Harrer commented on patch set 9 CR +1 V +1 05/10/24, 08:39
The changes seem to follow the usual rules and look plausible to me. The tests run successfully in the local test environment. -
André Buchmann updated the commit message in patch set 10
CR +1V +105/10/24, 10:42 -
Eric Harrer voted on patch set 10 CR +1 V +1 05/10/24, 10:42
-
core-ci voted on patch set 10 V +1 05/10/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57478
-
Oliver Klee voted on patch set 10 V +1 05/10/24, 11:25
-
Benni Mack voted on patch set 10 CR +2 V +2 05/13/24, 06:43
-
Benni Mack merged patch set 11 05/13/24, 06:43