83321[TASK] Provide lib.parseFunc via ext:frontend
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3249
Show 1624 earlier messages
-
Benjamin Kott uploaded patch set 1 03/08/24, 08:46
-
core-ci voted on patch set 1 V -1 03/08/24, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54210
-
Benjamin Franzke uploaded patch set 2
V -103/26/24, 07:50split patches -
core-ci voted on patch set 2 V +1 03/26/24, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54946
-
Benjamin Franzke uploaded patch set 3
V +103/26/24, 08:28 -
core-ci voted on patch set 3 V +1 03/26/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54948
-
Benjamin Franzke uploaded patch set 4
V +103/26/24, 09:04 -
Benjamin Franzke voted on patch set 4 CR +1 V +1 03/26/24, 09:06
-
core-ci voted on patch set 4 V -1 03/26/24, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54950
-
Benjamin Franzke uploaded patch set 5
CR +1V +103/26/24, 09:54 -
core-ci voted on patch set 5 V -1 03/26/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54952
-
Benni Mack commented on patch set 5 03/26/24, 10:10
setup.typoscript:26I would skip this target handling entirelysetup.typoscript:68should we adapt to something more typical? "table-content"?setup.typoscript:85I think we can skip this onesetup.typoscript:114remapTag is probably not needed anymoresetup.typoscript:115I would skip nonWrappedTag in the future -
Benni Mack commented on patch set 5 03/26/24, 10:10
ext_localconf.php:14can we handle this part in a separate change? -
Benjamin Franzke uploaded patch set 6
V -103/26/24, 14:14 -
Benjamin Franzke commented on patch set 6 CR -1 03/26/24, 14:20
TypoLinkGeneratorTest.php:574I've added this adaption because of https://git.typo3.org/typo3/CI/cms/-/jobs/3140506 I think this reveals that this patch is BREAKING in it's current state: We can not define `lib.parseFunc` by default, that's already a breaking change for users that define a custom `parseFunc` and do not use FSC. I know you wanted to make this a new default, that is always set, but I currently tend to think it's better to depend on `typo3/frontend` – possible once we have https://review.typo3.org/c/Packages/TYPO3.CMS/+/83526/22/typo3/sysext/styleguide/Configuration/Profiles/Styleguide/profile.yaml – explictly and do not introduce new default typoscript.ext_localconf.php:14Reply -
core-ci voted on patch set 6 V +1 03/26/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54974
-
Christian Kuhn commented on patch set 6 04/09/24, 07:35
ConstantAwareTokenStream.php:53It's an interesting idea to allow a syntax like ${constantName1 ?? constantName2}. I think we need to somehow have this added to the Tokeninzer, though: maybe some 'constantNullable' token that represents the ??, then see here if peekNext() of the tokenStream is such a token, then act accordingly. That's one option. We could also keep it that way, but it smells unclean - for instance we can't analyze this in other modules (i'd like to show you an example / thoughts on this, Benjamin). Not entirely sure how to approach it to end up with a properly modeled token stream. If we agree we need such a thing, we should have a talk on which options we have, Benjamin. -
Benjamin Kott uploaded patch set 7
CR -1V +106/14/24, 09:19 -
core-ci voted on patch set 7 V -1 06/14/24, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59582
-
Benjamin Kott uploaded patch set 8
V -106/14/24, 09:29 -
Benjamin Kott commented on patch set 8 06/14/24, 09:29
setup.typoscript:26ReplyDonesetup.typoscript:68Replythere is no benefit aside from beeing breaking for renaming the classsetup.typoscript:85ReplyDonesetup.typoscript:114ReplyDonesetup.typoscript:115Replyas discussed, we need to keep it for now, we would brake systems when removing it, -
Benjamin Kott commented on patch set 8 06/14/24, 09:30
ConstantAwareTokenStream.php:53ReplyDoneTypoLinkGeneratorTest.php:574ReplyDone -
core-ci voted on patch set 8 V -1 06/14/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59583
-
Benjamin Kott uploaded patch set 9
V -106/21/24, 06:13
-
core-ci voted on patch set 9 V -1 06/21/24, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59969
-
Benjamin Kott uploaded patch set 10
V -106/21/24, 06:21 -
core-ci voted on patch set 10 V +1 06/21/24, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59970
-
Benni Mack uploaded patch set 11
V +106/21/24, 07:15 -
Benni Mack commented on patch set 11 CR +1 V +1 06/21/24, 07:19
setup.typoscript:68ReplyDonesetup.typoscript:115ReplyDone -
core-ci voted on patch set 11 V +1 06/21/24, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59975
-
Benni Mack commented on patch set 12
CR +1V +106/21/24, 07:21Published edit on patch set 11. -
Benni Mack commented on patch set 13 06/21/24, 07:22
Published edit on patch set 12. -
core-ci voted on patch set 12 V +1 06/21/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59976
-
Benni Mack commented on patch set 14 06/21/24, 07:28
Published edit on patch set 13. -
core-ci voted on patch set 13 V +1 06/21/24, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59977
-
core-ci voted on patch set 14 V +1 06/21/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59978
-
Benjamin Kott uploaded patch set 15
V +106/21/24, 10:29 -
core-ci voted on patch set 15 V +1 06/21/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59991
-
Benni Mack voted on patch set 15 CR +1 V +1 06/21/24, 11:23
-
Simon Schaufelberger uploaded patch set 16
CR +1V +106/21/24, 13:10 -
Simon Schaufelberger voted on patch set 16 CR +1 06/21/24, 13:12
-
core-ci voted on patch set 16 V +1 06/21/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60022
-
Benni Mack commented on patch set 17
CR +1V +106/21/24, 13:43Published edit on patch set 16. -
Benni Mack voted on patch set 17 CR +1 V +1 06/21/24, 13:43
-
core-ci voted on patch set 17 V +1 06/21/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60024
-
Oli Bartsch voted on patch set 17 CR +2 V +2 06/21/24, 14:16
-
Oli Bartsch voted on patch set 17 CR +1 V +1 06/21/24, 14:17
-
Benjamin Kott voted on patch set 17 CR +2 V +2 06/24/24, 06:45
-
Benjamin Kott merged patch set 18 06/24/24, 06:46