Review main Merged

83355[TASK] Replace sql int casts with `ExpressionBuilder::castInt()`

Stefan Bürk CR +2 V +2 Easy +18 −15 updated 03/08/24, 13:16

Commit message

Since #98503 the new TypoScript parser is used
in the frontend, which used a value list trick
to minimize database queries. That required to
do proper value casting for each list element,
which has been implementend manually with dbms
vendor aware handling.

Recently #103309 enriched the `ExpressionBuilder`
with a couple of additional expression methods,
including `castInt()` expression.

This change replaces the manual db aware integer
casting with the new `ExpressionBuilder::castInt()`
method within the TypoScript parser classes along
with the corresponding `@todo` marker.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 03/08/24, 11:44

  2. core-ci voted on patch set 1 V +1 03/08/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54240

  3. Benni Mack voted on patch set 1 CR +1 V +1 03/08/24, 13:00

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 03/08/24, 13:05

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 03/08/24, 13:06

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 03/08/24, 13:16

  7. Stefan Bürk merged patch set 2 03/08/24, 13:16