Review main Merged

83395[BUGFIX] Proper URI generation in workspace preview for records

Can Adrian Karadag CR +2 V +2 Easy +3 −0 updated 03/11/24, 13:46

Commit message

If a workspace is active, the URI for a record preview link did not consider to prefix additional arguments with a "&" separator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Can Adrian Karadag uploaded patch set 1 03/11/24, 07:31

  2. core-ci voted on patch set 1 V +1 03/11/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54349

  3. Garvin Hicking updated the commit message in patch set 2 V +1 03/11/24, 12:49

  4. Garvin Hicking commented on patch set 2 CR +1 V +1 03/11/24, 12:54

    Thanks a lot for the contribution; I could verify that it fixes the link generation. I adjusted the commit message and believe this bugfix should be backported to 12.4 too. 11.5 used the old hook, I believe there it was expected to add a '&' to the string variabled `$additionalGetVars` as first character.
  5. core-ci voted on patch set 2 V +1 03/11/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54362

  6. Christian Kuhn commented on patch set 2 CR +2 V +2 03/11/24, 13:38

    not a beauty - the link generation should use proper api instead. but since that's a straight bugfix, we should go with it.
  7. Christian Kuhn merged patch set 3 03/11/24, 13:46