Review main Merged

83401[BUGFIX] Avoid PHP undefined array access in BrowseLinksController

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 03/11/24, 15:07

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Christian Kuhn uploaded patch set 1 03/11/24, 13:24

  2. Christian Kuhn commented on patch set 1 03/11/24, 13:26

    v11 not directly affected - it does not have the 'sorting' functionality shown in the issue. skipping v11 since the change feels a little risky, so we skip it to not risk regressions.
  3. core-ci voted on patch set 1 V +1 03/11/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54363

  4. Oliver Klee voted on patch set 1 CR +1 03/11/24, 13:53

  5. Garvin Hicking commented on patch set 1 V -1 03/11/24, 14:28

    Let me check something quickly
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 03/11/24, 14:33

    OK, verified. I was curious if on a page with multiple editor instances the popup would still refer to the proper one when selecting a file after sorting (it works).
  7. Jasmina Ließmann voted on patch set 1 CR +1 V +1 03/11/24, 14:59

  8. Oliver Klee voted on patch set 1 V +1 03/11/24, 15:02

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 03/11/24, 15:07

  10. Christian Kuhn merged patch set 2 03/11/24, 15:07