Review main Merged

83406[TASK] Limit commit message line length to 72 characters

Ayke Halder CR +2 V +2 Easy +2 −2 updated 03/11/24, 22:49

Commit message

The commit messages line-length is documented as 72 characters. The
commit-msg hook checks for 72 characters now.

Before the hook checked for 74 characters.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Ayke Halder uploaded patch set 1 03/11/24, 15:09

  2. core-ci voted on patch set 1 V +1 03/11/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54372

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 03/11/24, 15:15

    Background: This is to align with the documentation and general git practice, also see slack chat on https://typo3.slack.com/archives/C03AM9R17/p1710168311371749
  4. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 03/11/24, 15:16

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 03/11/24, 15:16

  6. core-ci voted on patch set 2 V +1 03/11/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54373

  7. Stephan Großberndt voted on patch set 2 CR +1 03/11/24, 15:22

  8. Oliver Klee voted on patch set 2 CR +1 03/11/24, 15:35

  9. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 03/11/24, 16:35

  10. Benjamin Franzke voted on patch set 3 CR +1 V +1 03/11/24, 16:35

  11. core-ci voted on patch set 3 V +1 03/11/24, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54379

  12. Guido Schmechel voted on patch set 3 CR +1 03/11/24, 20:36

  13. Benni Mack voted on patch set 3 CR +2 V +2 03/11/24, 22:49

  14. Benni Mack merged patch set 4 03/11/24, 22:49