83449[TASK] Clean up code inconsistencies detected by phpstan
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −165
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+2 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+6 −7
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php+1 −1
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php2+2 −8
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+5 −1
- typo3/sysext/filelist/Classes/FileList.php+4 −8
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php3+9 −8
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/FileDeclaration.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php3+18 −25
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+3 −2
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+2 −3
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+3 −5
- typo3/sysext/webhooks/Tests/Functional/WebhookExecutionTest.php+5 −1
Review log 1824
-
Benni Mack uploaded patch set 1 03/13/24, 09:23
-
core-ci voted on patch set 1 V +1 03/13/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54461
-
Benni Mack updated the commit message in patch set 2
V +103/13/24, 09:46 -
core-ci voted on patch set 2 V +1 03/13/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54464
-
Benjamin Franzke commented on patch set 2 03/13/24, 10:19
-
Benni Mack uploaded patch set 3
V +103/13/24, 10:41 -
core-ci voted on patch set 3 V -1 03/13/24, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54468
-
Benni Mack uploaded patch set 4
V -103/13/24, 10:59 -
core-ci voted on patch set 4 V -1 03/13/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54469
-
Benni Mack uploaded patch set 5
V -103/13/24, 12:21 -
core-ci voted on patch set 5 V +1 03/13/24, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54474
-
Benni Mack commented on patch set 5 03/13/24, 13:03
DatabaseIntegrityController.php:1486Replyshould be fine now, I guess? -
Benjamin Franzke commented on patch set 5 03/13/24, 13:05
DatabaseIntegrityController.php:1486ReplyAcknowledged -
Benjamin Franzke commented on patch set 5 03/13/24, 13:32
ExtendedFileUtility.php:893`File|false|null` (see line 901 – or change that to `= false`)ContentObjectRenderer.php:2443Good catch by phpstan, the old condition never matched: ``` php > var_dump(empty(explode(',', ''))); bool(false) var_dump(empty([''])); bool(false) php > var_dump(explode(',', '') === ['']); bool(true) ``` Should we backport(?) -
Benni Mack commented on patch set 5 03/15/24, 15:44
ContentObjectRenderer.php:2443ReplyYes. Based on the code below, it would still return '' - I tried adding tests but they do not change depending on this change. -
Benni Mack commented on patch set 6
V +103/22/24, 15:11Published edit on patch set 5. -
Benjamin Franzke commented on patch set 5 03/22/24, 15:14
ContentObjectRenderer.php:2443ReplyAcknowledged -
Benjamin Franzke commented on patch set 6 03/22/24, 15:14
ExtendedFileUtility.php:893ReplyDone -
core-ci voted on patch set 6 V +1 03/22/24, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54850
-
Benjamin Franzke voted on patch set 6 CR +1 03/22/24, 15:17
-
Benjamin Franzke voted on patch set 6 V +1 03/22/24, 15:28
-
Stefan Bürk voted on patch set 6 CR +1 V +1 03/22/24, 16:00
-
Benni Mack voted on patch set 6 CR +2 V +2 03/22/24, 16:00
-
Benni Mack merged patch set 7 03/22/24, 16:01
DatabaseIntegrityController.php:1486