Review 11.5 Merged

83453[TASK] Add composer-mode to our acceptance test matrix

Benjamin Franzke CR +2 V +2 Expert +885 −198 updated 03/19/24, 05:31

Commit message

All applicable acceptance tests are now also executed
in composer mode. Tests that check classic-mode specific
functions are excluded and are therefore now tagged
as classic-mode test.

The composer mode instance is generated with our
CLI setup tools, allowing to mimic the realworld
case where a instance is creating via our setup tools
instead of from fixtures (which we still use for classic
mode tests, but try to reducde/avoid for composer mode tests).

The existing existing classic-mode test acceptance test
execution will keep running as-is.

The v12 backport additionally imports pieces from #102440
as t3editor extension is enabled in this composer-mode,
while v12 classic mode is tested (for historic reasons)
without t3editor extension enabled.

Commands executed:

  > composer require --dev "typo3/cms-styleguide":"~11.5.5"

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 47

Show 27 more files

Review log 2668

Show 1643 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/13/24, 12:04

  2. core-ci voted on patch set 1 V -1 03/13/24, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54473

  3. Benjamin Franzke marked it work in progress 03/13/24, 12:16

  4. Benjamin Franzke uploaded patch set 2 V -1 03/13/24, 12:40

  5. core-ci voted on patch set 2 V -1 03/13/24, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54475

  6. Benjamin Franzke uploaded patch set 3 V -1 03/13/24, 13:33

  7. core-ci voted on patch set 3 V -1 03/13/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54478

  8. Benjamin Franzke uploaded patch set 4 V -1 03/13/24, 14:29

  9. core-ci voted on patch set 4 V -1 03/13/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54483

  10. Benjamin Franzke uploaded patch set 5 V -1 03/13/24, 15:14

  11. core-ci voted on patch set 5 V -1 03/13/24, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54484

  12. Benjamin Franzke uploaded patch set 6 V -1 03/13/24, 16:55

  13. core-ci voted on patch set 6 V -1 03/13/24, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54497

  14. core-ci commented on patch set 6 03/14/24, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54497

  15. Benjamin Franzke uploaded patch set 7 V -1 03/14/24, 07:34

  16. core-ci voted on patch set 7 V -1 03/14/24, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54513

  17. core-ci commented on patch set 7 03/14/24, 08:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54513

  18. Benjamin Franzke uploaded patch set 8 V -1 03/14/24, 12:11

  19. Benjamin Franzke uploaded patch set 9 03/14/24, 12:25

  20. core-ci voted on patch set 8 V -1 03/14/24, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54537

  21. core-ci voted on patch set 9 V -1 03/14/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54538

  22. core-ci commented on patch set 9 03/14/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54538

  23. Benjamin Franzke uploaded patch set 10 V -1 03/14/24, 14:03

  24. core-ci voted on patch set 10 V +1 03/14/24, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54541

  25. Benjamin Franzke uploaded patch set 11 V +1 03/14/24, 14:33

  26. core-ci voted on patch set 11 V -1 03/14/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54542

  27. core-ci commented on patch set 11 03/14/24, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54542

  28. core-ci commented on patch set 11 03/14/24, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54542

  29. core-ci commented on patch set 11 03/14/24, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54542

  30. core-ci commented on patch set 11 03/14/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54542

  31. core-ci commented on patch set 11 03/14/24, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54543

  32. Benjamin Franzke uploaded patch set 12 V -1 03/14/24, 16:13

  33. Benjamin Franzke uploaded patch set 13 03/14/24, 16:19

  34. core-ci voted on patch set 12 V -1 03/14/24, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54546

  35. core-ci voted on patch set 13 V -1 03/14/24, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54547

  36. core-ci commented on patch set 13 03/14/24, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54547

  37. core-ci commented on patch set 13 03/14/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54547

  38. core-ci commented on patch set 13 03/14/24, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54547

  39. core-ci commented on patch set 13 03/14/24, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54547

  40. core-ci commented on patch set 13 03/14/24, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54549

  41. Benjamin Franzke uploaded patch set 14 V -1 03/16/24, 07:07

  42. core-ci voted on patch set 14 V -1 03/16/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54609

  43. Benjamin Franzke uploaded patch set 15 V -1 03/16/24, 07:38

  1. core-ci voted on patch set 15 V -1 03/16/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54610

  2. core-ci commented on patch set 15 03/16/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54610

  3. Benjamin Franzke uploaded patch set 16 V -1 03/16/24, 09:04

  4. core-ci voted on patch set 16 V -1 03/16/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54611

  5. core-ci commented on patch set 16 03/16/24, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54611

  6. Benjamin Franzke uploaded patch set 17 V -1 03/16/24, 10:16

  7. Benjamin Franzke uploaded patch set 18 03/16/24, 10:32

  8. core-ci voted on patch set 17 V -1 03/16/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54614

  9. core-ci voted on patch set 18 V -1 03/16/24, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54616

  10. Benjamin Franzke uploaded patch set 19 V -1 03/16/24, 11:05

  11. core-ci voted on patch set 19 V -1 03/16/24, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54618

  12. core-ci voted on patch set 19 V +1 03/16/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54618

  13. core-ci voted on patch set 19 V -1 03/16/24, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54619

  14. core-ci commented on patch set 19 03/16/24, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54619

  15. core-ci commented on patch set 19 03/16/24, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54619

  16. Benjamin Franzke uploaded patch set 20 V -1 03/16/24, 13:46

  17. core-ci voted on patch set 20 V +1 03/16/24, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54624

  18. core-ci commented on patch set 20 03/16/24, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54625

  19. Benjamin Franzke uploaded patch set 21 V +1 03/16/24, 14:27

  20. core-ci voted on patch set 21 V +1 03/16/24, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54626

  21. core-ci commented on patch set 21 03/16/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54627

  22. Benjamin Franzke marked it ready for review 03/16/24, 15:16

  23. Christian Kuhn voted on patch set 21 CR +1 V +1 03/17/24, 14:00

  24. Benjamin Franzke voted on patch set 21 CR +2 V +2 03/19/24, 05:31

  25. Benjamin Franzke merged patch set 22 03/19/24, 05:31