83494[BUGFIX] Use correct icon for pages table
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1922
-
Georg Ringer uploaded patch set 1 03/15/24, 14:08
-
Georg Ringer commented on patch set 1 03/15/24, 14:08
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/15/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54593
-
Andreas Kienast commented on patch set 1 03/15/24, 14:20
IconFactory.php:215Why is `$row['content_from_pid']` an array in the first place? This looks like another bug that rather should be solved. -
Andreas Kienast commented on patch set 1 03/15/24, 14:41
IconFactory.php:215ReplyI've debugged this now. `pages.content_from_pid` is defined in TCA as a `group` field. FormEngine's `FormDataProvider\TcaGroup` converts the value to an array then. -
Andreas Kienast commented on patch set 1 03/15/24, 15:12
I've pushed an alternative approach at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83495. Let's wait for feedback from lolli. -
Georg Ringer rebased onto patch set 2
V +103/19/24, 15:18 -
Georg Ringer commented on patch set 2 03/19/24, 15:18
Reply
looks better to me -
core-ci voted on patch set 2 V +1 03/19/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54701
-
Riccardo De Contardi commented on patch set 2 V +1 03/30/24, 10:13
tested on latest main; edit page with the following doktypes: home, standard , shortcut, sysfolder, external url, mount point,separator (also with attributes: not in menu, hidden, extend to subpages,starttime, endtime,content_from_pid) -
Jörg Bösche voted on patch set 2 CR +1 04/04/24, 06:32
-
Andreas Kienast commented on patch set 2 CR -1 04/04/24, 07:22
-1 for now until a final decision is made about the proposed alternative. My main concern is that FormEngine internals are now introduced to the IconFactory. -
Christian Kuhn commented on patch set 2 04/07/24, 07:49
Reply
Well. IconFactory->mapRecordTypeToIconIdentifier() is pretty much tailored for FormEngine only, and already contains similar code that deals with arrays. As such, I'd go this way and eventually resolved the method `@todo` at some point by modeling the method as part of FormEngine. -
Andreas Kienast voted on patch set 2 CR 0 04/07/24, 10:59
-
Christian Kuhn commented on patch set 2 04/07/24, 11:20
IconFactory.php:215ReplyDone -
Georg Ringer rebased onto patch set 3
CR +1V +104/07/24, 11:20 -
Christian Kuhn voted on patch set 3 CR +1 V +1 04/07/24, 11:21
-
core-ci voted on patch set 3 V +1 04/07/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55504
-
Andreas Kienast voted on patch set 3 CR +1 V +1 04/07/24, 15:19
-
Stefan Bürk voted on patch set 3 CR +1 V +1 04/07/24, 16:12
-
Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/24, 06:53
-
Christian Kuhn merged patch set 4 04/08/24, 06:53