Review main Merged

83499[FEATURE] Request id as reference in error handler output

Christoph Lehmann CR +2 V +2 Normal +56 −32 updated 03/23/24, 20:56

Commit message

The ProductionExceptionHandler in EXT:core outputs error details, but not for every one. As a normal visitor you don't see any tracable error information.

The ProductionExceptionHandler in EXT:frontend outputs "Oops, an error occurred!" followed by a timestamp + a hash. This is part of log messages.

Whenever an error/exception is logged, the log message contains the request id.

With this the request id is also shown in web output of error/exception handlers as public visible error reference.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Christoph Lehmann uploaded patch set 1 03/17/24, 11:37

  2. core-ci voted on patch set 1 V -1 03/17/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54636

  3. Christoph Lehmann uploaded patch set 2 V -1 03/20/24, 21:25

  4. core-ci voted on patch set 2 V -1 03/20/24, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54752

  5. Christoph Lehmann uploaded patch set 3 V -1 03/20/24, 21:58

  6. core-ci voted on patch set 3 V -1 03/20/24, 22:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54753

  7. Christoph Lehmann uploaded patch set 4 V -1 03/20/24, 22:20

  8. core-ci voted on patch set 4 V +1 03/20/24, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54754

  9. Simon Schaufelberger commented on patch set 4 03/20/24, 22:57

    finally some useful information available 👍
  10. Andreas Kienast voted on patch set 4 CR +1 03/21/24, 15:40

  11. Andreas Kienast voted on patch set 4 V +1 03/21/24, 16:07

  12. Benni Mack voted on patch set 4 CR +2 V +2 03/23/24, 20:56

  13. Benni Mack merged patch set 5 03/23/24, 20:56