Review main Merged

83500[TASK] Align table restriction fields in backend usergroup record

Jasmina Ließmann CR +2 V +2 Easy +10 −1 updated 03/19/24, 12:28

Commit message

In order to get a better overview of the selected table restrictions,
the two corresponding fields are placed next to each other.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Markus Klein +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1214

  1. Jasmina Ließmann uploaded patch set 1 03/18/24, 09:13

  2. Mathias Brodala updated the commit message in patch set 2 03/18/24, 09:16

  3. core-ci voted on patch set 1 V +1 03/18/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54647

  4. core-ci voted on patch set 2 V +1 03/18/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54648

  5. Christian Kuhn commented on patch set 2 CR +1 V +1 03/18/24, 09:29

    this is so much better, using existing core functionality, leading to a very simple code solution.
  6. Marcin Sągol commented on patch set 2 03/18/24, 13:36

    be_groups.php:281

    I wonder if we could add here, as a palette description, information that: "All tables that are allowed for modification (see below) are also allowed for read access, so no need to select them in this list as well." - as the docs state https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Backend/AccessControl/AccessControlOptions/Index.html
  7. Jasmina Ließmann commented on patch set 2 03/18/24, 14:15

    be_groups.php:281 Reply

    I'm not sure. In general, I am always available for descriptive texts, but this added value would apply to all fields in the backend usergroup record. In addition, the text would have to be kept up to date if something changes in the documentation.
  8. Marcin Sągol commented on patch set 2 03/18/24, 14:40

    be_groups.php:281 Reply

    In this case I think not many will know that they can skip the one list if they have tables selected for modification. That is why i proposed this addition :)
  9. Christian Kuhn commented on patch set 2 03/18/24, 18:01

    be_groups.php:281 Reply

    The patch changes nothing regarding the connection of the two fields. The situation, that 'modify' is an implicit 'list', is unclear and undocumented already. We could improve that with a different patch?
  10. Markus Klein commented on patch set 2 CR +1 03/18/24, 19:48

    I would even opt to backport this to v12
  11. Markus Klein voted on patch set 2 V +1 03/19/24, 08:51

  12. Christian Kuhn commented on patch set 2 03/19/24, 11:07

    be_groups.php:281 Reply

    marcin is ok with this, setting resolved.
  13. Jasmina Ließmann voted on patch set 2 CR +2 V +2 03/19/24, 12:28

  14. Jasmina Ließmann merged patch set 3 03/19/24, 12:28