Review 12.4 Merged

83518[TASK] Apply some runTests.sh cleanups

Benjamin Franzke CR +2 V +2 Easy +25 −7 updated 03/19/24, 13:16

Commit message

* Always clean-up containers when Control-C is pressed
 * Enforce removing networks even if some containers have not been
   fully stopped (does not work with older docker versions, therefore
   only enabled for podman)
 * Bail out if `waitFor` failed instead of resuming with subsequent
   commands
 * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode
 * Do not derive `--pull=never` from the `$CI` environment variable, as
   `$CI` is set both in gitlab [1] and github [2] actions.
   runTests.sh might be used in github actions, therefore this flag is
   moved into our gitlab-ci specific configuration.
 * Fix typos

[1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
[2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 511

  1. Benjamin Franzke uploaded patch set 1 03/19/24, 09:27

  2. core-ci voted on patch set 1 V -1 03/19/24, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54681

  3. core-ci commented on patch set 1 03/19/24, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54681

  4. core-ci commented on patch set 1 03/19/24, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54681

  5. Benjamin Franzke rebased onto patch set 2 V -1 03/19/24, 09:50

  6. core-ci voted on patch set 2 V -1 03/19/24, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54682

  7. core-ci voted on patch set 2 V +1 03/19/24, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54682

  8. Benjamin Franzke uploaded patch set 3 V +1 03/19/24, 10:48

  9. core-ci voted on patch set 3 V +1 03/19/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54685

  10. Benjamin Franzke voted on patch set 3 CR +2 V +2 03/19/24, 13:16

  11. Benjamin Franzke merged patch set 4 03/19/24, 13:16