Review main Merged

83528[TASK] Adjust title and action columns in history/undo view

Jasmina Ließmann CR +2 V +2 Easy +19 −9 updated 04/10/24, 16:21

Commit message

To better identify the different record types, the record icon is now
displayed next to the record title and some unnecessary double quotes
are removed. The actions are now displayed as badges.

Also, in the h1 the table name and UID have been removed.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 912

  1. Jasmina Ließmann uploaded patch set 1 03/20/24, 10:36

  2. core-ci voted on patch set 1 V +1 03/20/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54716

  3. Riccardo De Contardi commented on patch set 1 V +1 03/30/24, 09:59

    I'd try to use different colors for the various badges (modified|inserted|deleted)
  4. Jasmina Ließmann updated the commit message in patch set 2 V +1 04/06/24, 08:24

  5. Jasmina Ließmann updated the commit message in patch set 3 04/06/24, 08:25

  6. core-ci voted on patch set 2 V +1 04/06/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55426

  7. core-ci voted on patch set 3 V +1 04/06/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55427

  8. Jasmina Ließmann commented on patch set 3 04/06/24, 08:35

    Reply

    I tried it, but it felt a bit too colorful for me (there are currently 6 different action types in the RecordHistoryStore). It could be retrofitted if necessary.
  9. Stefan Bürk voted on patch set 3 CR +1 V +1 04/10/24, 14:33

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 04/10/24, 15:38

  11. Jasmina Ließmann voted on patch set 3 CR +2 V +2 04/10/24, 16:21

  12. Jasmina Ließmann merged patch set 4 04/10/24, 16:21