83528[TASK] Adjust title and action columns in history/undo view
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 6
- Build/Sources/Sass/component/_table.scss+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+3 −2
- typo3/sysext/backend/Resources/Private/Language/locallang_show_rechis.xlf+1 −1
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/History.html+12 −3
- typo3/sysext/backend/Resources/Private/Templates/RecordHistory/Main.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
Review log 912
-
Jasmina Ließmann uploaded patch set 1 03/20/24, 10:36
-
core-ci voted on patch set 1 V +1 03/20/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54716
-
Riccardo De Contardi commented on patch set 1 V +1 03/30/24, 09:59
I'd try to use different colors for the various badges (modified|inserted|deleted) -
Jasmina Ließmann updated the commit message in patch set 2
V +104/06/24, 08:24 -
Jasmina Ließmann updated the commit message in patch set 3 04/06/24, 08:25
-
core-ci voted on patch set 2 V +1 04/06/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55426
-
core-ci voted on patch set 3 V +1 04/06/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55427
-
Jasmina Ließmann commented on patch set 3 04/06/24, 08:35
Reply
I tried it, but it felt a bit too colorful for me (there are currently 6 different action types in the RecordHistoryStore). It could be retrofitted if necessary. -
Stefan Bürk voted on patch set 3 CR +1 V +1 04/10/24, 14:33
-
Christian Kuhn voted on patch set 3 CR +1 V +1 04/10/24, 15:38
-
Jasmina Ließmann voted on patch set 3 CR +2 V +2 04/10/24, 16:21
-
Jasmina Ließmann merged patch set 4 04/10/24, 16:21