Review main Merged

83559[BUGFIX] Prevent undefined array index in GifBuilder

Oli Bartsch CR +2 V +2 Easy +8 −3 updated 03/22/24, 12:33

Commit message

Unset non matching key arrays and additionally
secure the array access with a corresponding
check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 03/21/24, 13:03

  2. core-ci voted on patch set 1 V +1 03/21/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54791

  3. Oliver Klee updated the commit message in patch set 2 V +1 03/21/24, 13:17

  4. core-ci voted on patch set 2 V +1 03/21/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54796

  5. Benni Mack voted on patch set 2 CR +1 V +1 03/21/24, 23:04

  6. Stefan Bürk voted on patch set 2 CR +1 03/22/24, 09:06

  7. Stefan Bürk voted on patch set 2 V +1 03/22/24, 09:11

  8. Simon Schaufelberger commented on patch set 2 03/22/24, 09:50

    should this also be backported for 11.5?
  9. Oli Bartsch commented on patch set 2 03/22/24, 11:14

    Reply

    No
  10. Oli Bartsch voted on patch set 2 CR +2 V +2 03/22/24, 12:32

  11. Oli Bartsch merged patch set 3 03/22/24, 12:33