Review 12.4 Merged

83570[BUGFIX] Prevent undefined array index in GifBuilder

Oli Bartsch CR +2 V +2 Easy +8 −3 updated 03/22/24, 12:33

Commit message

Unset non matching key arrays and additionally
secure the array access with a corresponding
check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Oli Bartsch uploaded patch set 1 03/22/24, 11:17

  2. Oli Bartsch uploaded patch set 2 03/22/24, 11:18

  3. Oli Bartsch uploaded patch set 3 03/22/24, 11:19

  4. core-ci voted on patch set 1 V -1 03/22/24, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54841

  5. core-ci voted on patch set 2 V -1 03/22/24, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54842

  6. core-ci voted on patch set 3 V +1 03/22/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54843

  7. Oli Bartsch voted on patch set 3 CR +2 V +2 03/22/24, 12:33

  8. Oli Bartsch merged patch set 4 03/22/24, 12:33