Review main Merged

83573[BUGFIX] Check language access for edit default metadata

Oli Bartsch CR +2 V +2 Normal +41 −22 updated 03/25/24, 15:05

Commit message

At various places, it's possible to edit the metadata
of a file in the default language. However, users might
not have access to the default language. To prevent
moving to FormEngine and facing access permission
errors, those places now use proper language access
checks and do not display corresponding action if
the user does not have access.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1216

  1. Oli Bartsch uploaded patch set 1 03/22/24, 17:12

  2. core-ci voted on patch set 1 V +1 03/22/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54857

  3. Jochen Roth voted on patch set 1 CR +1 V +1 03/23/24, 10:51

  4. Stefan Bürk commented on patch set 1 03/24/24, 16:45

    FileList.php:501

    Why not adding the attribute generally ? ( true and false )

    Tiles.html:58

    Why not adding the attribute in all cases (true + false) like draggable ?
  5. Stefan Bürk voted on patch set 1 V +1 03/24/24, 17:45

  6. Oli Bartsch commented on patch set 1 03/24/24, 19:52

    FileList.php:501 Reply

    not needed and therefore would blow HTML Markup unnecessary

    Tiles.html:58 Reply

    not needed and therefore would blow HTML Markup unnecessary
  7. Stefan Bürk commented on patch set 1 CR +1 03/24/24, 20:11

    FileList.php:501 Reply

    ack.

    Tiles.html:58 Reply

    ack.
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 03/24/24, 22:08

  9. core-ci voted on patch set 2 V -1 03/24/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54907

  10. core-ci commented on patch set 2 03/25/24, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54907

  11. Oli Bartsch uploaded patch set 3 V -1 03/25/24, 11:59

  12. core-ci voted on patch set 3 V +1 03/25/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54928

  13. Jochen Roth voted on patch set 3 CR +1 V +1 03/25/24, 14:35

  14. Stefan Bürk voted on patch set 3 CR +1 V +1 03/25/24, 14:51

  15. Oli Bartsch voted on patch set 3 CR +2 V +2 03/25/24, 15:05

  16. Oli Bartsch merged patch set 4 03/25/24, 15:05