Review 12.4 Merged

83616[BUGFIX] Correctly cast folder's 'mtime' and 'ctime' as integer

Albrecht Köhnlein CR +2 V +2 Easy +2 −2 updated 04/01/24, 07:34

Commit message

When opening the "tile view" in the backend, third party FAL adapters
may not correctly return 'mtime' and 'ctime' as integers.
This already is fixed in the main branch but can occur in TYPO3 12 LTS
as well, therefore relevant changes are picked from #101469.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Sybille Peters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 2228

Show 23 earlier messages
  1. Albrecht Köhnlein uploaded patch set 1 03/28/24, 06:54

  2. Albrecht Köhnlein updated the commit message in patch set 2 03/28/24, 06:54

  3. core-ci voted on patch set 1 V -1 03/28/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55013

  1. core-ci voted on patch set 2 V -1 03/28/24, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55014

  2. Simon Schaufelberger commented on patch set 2 03/28/24, 10:05

    Please also copy the change-id from the commit from main to make it an official backport
  3. Albrecht Köhnlein commented on patch set 2 03/28/24, 14:51

    Reply

    As part of the body text or in the related, resolved etc. properties? Which format is required?
  4. Simon Schaufelberger commented on patch set 2 03/28/24, 16:12

    Reply

    As part of the body text. That way the Changes will be linked together.
  5. Albrecht Köhnlein updated the commit message in patch set 3 V -1 03/28/24, 19:13

  6. Simon Schaufelberger commented on patch set 3 03/28/24, 19:33

    Reply

    I meant the last line, not within the message
    No, I me
  7. Albrecht Köhnlein updated the commit message in patch set 4 03/28/24, 20:09

  8. core-ci voted on patch set 3 V -1 03/28/24, 23:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55042

  9. core-ci voted on patch set 4 V -1 03/29/24, 00:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55046

  10. Benjamin Franzke updated the commit message in patch set 5 V -1 03/29/24, 04:26

  11. Benjamin Franzke commented on patch set 5 03/29/24, 04:26

    Reply

    This has a separate issue id and is actually a separate bugfix (the main patch did alot more) and has a completely different commit message. We don't use the same changeid in this case. I edited the commit message accordingly.
  12. Benjamin Franzke rebased onto patch set 6 03/29/24, 04:29

    Rebase
  13. core-ci voted on patch set 6 V +1 03/29/24, 04:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55053

  14. Georg Ringer voted on patch set 6 CR +1 V +1 03/29/24, 07:35

  15. Oliver Klee voted on patch set 6 CR +1 V +1 03/29/24, 08:58

  16. Oliver Klee commented on patch set 6 03/29/24, 08:58

    Is 11.5 affected as well?
  17. Albrecht Köhnlein commented on patch set 6 03/29/24, 10:07

    Reply

    Not as far as I can see. The "tile view" was introduced in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77592 for TYPO3 12
  18. Albrecht Köhnlein updated the commit message in patch set 7 CR +1 V +1 03/29/24, 10:09

  19. core-ci voted on patch set 7 V +1 03/29/24, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55061

  20. Oliver Klee commented on patch set 7 03/29/24, 10:39

    Reply

    Acknowledged
  21. Sybille Peters voted on patch set 7 CR +1 03/30/24, 05:39

  22. Oliver Klee voted on patch set 7 CR +1 V +1 03/30/24, 10:24

  23. Simon Schaufelberger voted on patch set 7 CR +1 V +1 03/30/24, 13:56

  24. Christian Kuhn voted on patch set 7 CR +2 V +2 04/01/24, 07:34

  25. Christian Kuhn merged patch set 8 04/01/24, 07:34