Review main Merged

83627[TASK] Remove unnecessary typecasts in ext:recycler

Torben Hansen CR +2 V +2 Easy +1 −3 updated 03/31/24, 20:12

Commit message

Function argument types of the `resolveTree` function in
the `DeleteRecords` class already use strict types, so the
following typecasts can safely be removed.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Torben Hansen uploaded patch set 1 03/30/24, 06:13

  2. Torben Hansen updated the commit message in patch set 2 03/30/24, 06:16

  3. core-ci voted on patch set 1 V -1 03/30/24, 06:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55081

  4. core-ci voted on patch set 2 V -1 03/30/24, 06:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55082

  5. Oliver Klee commented on patch set 2 03/30/24, 10:24

    DeletedRecords.php:506

    Do we still need the `abs` call?
  6. Torben Hansen uploaded patch set 3 V -1 03/30/24, 11:07

  7. Torben Hansen commented on patch set 3 03/30/24, 11:08

    DeletedRecords.php:506 Reply

    We have several places in our codebase, where an id or uid can be negative. I'm pretty sure, this does not affect this function, but to be safe the change does not break something, the `abs` call now remains.
  8. core-ci voted on patch set 3 V -1 03/30/24, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55084

  9. Torben Hansen updated the commit message in patch set 4 V -1 03/31/24, 06:04

  10. core-ci voted on patch set 4 V -1 03/31/24, 06:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55102

  11. Oliver Klee commented on patch set 4 03/31/24, 08:26

    The fix for the CI failure was merged yesterday: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83630 So this either needs a rebase, or we restart the CI build in April. :-)
  12. Torben Hansen rebased onto patch set 5 V -1 03/31/24, 13:32

  13. core-ci voted on patch set 5 V +1 03/31/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55105

  14. Oliver Klee voted on patch set 5 CR +1 V +1 03/31/24, 13:39

  15. Nikita Hovratov voted on patch set 5 CR +2 V +2 03/31/24, 20:12

  16. Nikita Hovratov merged patch set 6 03/31/24, 20:12