Review main Merged

83683[TASK] Remove IS ext_conf_template.txt maxAge

Christian Kuhn CR +2 V +2 Easy +2 −26 updated 04/08/24, 06:42

Commit message

The config label:

"Deprecated! Max TTL (hours) for indexed page: The time in hours
that is the maximum age of an indexed page before it will get indexed
again. Usually the index is kept consistent, therefore you won't need
this feature."

This message is there since ... *doing some git archaeology* ...
SVN id 2006 in year 2007! That's the Changelog entry:

"Turn off maxAge setting as this "feature" seems to make no sense
at all."

Agreed: When content is changed in BE, an IS hook removes the
page index, and it will be re-indexed with next call (or via
crawler). It seems it's finally time to remove the option plus
the attached code without further notice ;)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1011

  1. Christian Kuhn uploaded patch set 1 04/07/24, 08:47

  2. core-ci voted on patch set 1 V +1 04/07/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55495

  3. Stefan Bürk voted on patch set 1 CR +1 04/07/24, 09:58

  4. Andreas Kienast voted on patch set 1 CR +1 04/07/24, 10:56

  5. Stefan Bürk voted on patch set 1 V +1 04/07/24, 11:26

  6. Oliver Klee voted on patch set 1 CR +1 04/07/24, 12:07

  7. Andreas Kienast voted on patch set 1 V +1 04/07/24, 15:15

  8. Chris Müller commented on patch set 1 04/07/24, 16:32

    ext_conf_template.txt:34

    As far as I checked, the indexedsearch.config.maxAge key can also be removed from locallang_em.xlf.
  9. Stefan Bürk commented on patch set 1 04/07/24, 21:00

    ext_conf_template.txt:34 Reply

  10. Christian Kuhn voted on patch set 1 CR +2 V +2 04/08/24, 06:42

  11. Christian Kuhn merged patch set 2 04/08/24, 06:42