Review main Merged

83691[TASK] Avoid indexed_search EXTCONF addRootLineFields

Christian Kuhn CR +2 V +2 Easy +0 −17 updated 04/08/24, 06:56

Commit message

Did you know about
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['indexed_search']['addRootLineFields']?

No? Well, that's probably because *nobody* does! According to
a TER search, it has never been used.

Why? Well, it's an undocumented feature in a detail functionality
of indexed_search, and last traces at more obvious places have
been removed in v6.0.

To use it, a developer not only needs to understand the details
of 'rootline_uids' in indexed_search, it also needs to find that
"hook", grasp it, add a database field in table index_section,
and add FE rendering to deal with it.

The patch removes this code without substitution: It has never
been used in the wild, is not documented, is most likely broken
if anyone actually tries to use it, there has never been a
single issue in forge related to it, it is embedded in an area that
is hard to understand in the first place, it could be resolved
using an XCLASS more easily, and its naming collides with the
well-known FE addRootLineFields, which is of course a totally
different thing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/07/24, 12:32

  2. core-ci voted on patch set 1 V +1 04/07/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55507

  3. Stefan Bürk voted on patch set 1 CR +1 04/07/24, 13:33

  4. Stefan Bürk voted on patch set 1 V +1 04/07/24, 13:35

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 04/07/24, 16:16

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/08/24, 06:56

  7. Christian Kuhn merged patch set 2 04/08/24, 06:56