Review main Merged

83696[TASK] Use site sets in EXT:styleguide

Benjamin Franzke CR +2 V +2 Hard +338 −88 updated 04/26/24, 07:22

Commit message

Provide a new (default) EXT:styleguide frontend
generator that uses site set infrastructure
provided by #103437, #103439 and #103522.

The old sys_template-root based renderer is
preserved and tested independently

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 28

Show 8 more files

Review log 2440

Show 815 earlier messages
  1. Benjamin Franzke uploaded patch set 1 04/07/24, 21:54

  2. core-ci voted on patch set 1 V +1 04/07/24, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55519

  3. Benjamin Franzke rebased onto patch set 2 V +1 04/09/24, 17:40

  4. core-ci voted on patch set 2 V +1 04/09/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55627

  5. Benjamin Franzke rebased onto patch set 3 V +1 04/10/24, 17:30

  6. core-ci voted on patch set 3 V +1 04/10/24, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55703

  7. Benjamin Franzke uploaded patch set 4 V +1 04/10/24, 18:13

  8. core-ci voted on patch set 4 V +1 04/10/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55707

  9. Benjamin Franzke rebased onto patch set 5 V +1 04/11/24, 11:23

  10. core-ci voted on patch set 5 V +1 04/11/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55764

  11. Benjamin Franzke uploaded patch set 6 V +1 04/18/24, 07:22

  12. Benjamin Franzke marked it work in progress 04/18/24, 07:22

  13. core-ci voted on patch set 6 V -1 04/18/24, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56223

  14. Benjamin Franzke uploaded patch set 7 V -1 04/18/24, 08:15

  15. core-ci voted on patch set 7 V +1 04/18/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56231

  1. Benjamin Franzke rebased onto patch set 8 V +1 04/19/24, 07:28

  2. Benjamin Franzke marked it ready for review 04/19/24, 07:37

  3. core-ci voted on patch set 8 V +1 04/19/24, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56302

  4. Benjamin Franzke rebased onto patch set 9 V +1 04/19/24, 12:52

  5. core-ci voted on patch set 9 V +1 04/19/24, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56339

  6. Benjamin Franzke uploaded patch set 10 V +1 04/22/24, 07:10

  7. core-ci voted on patch set 10 V +1 04/22/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56470

  8. core-ci commented on patch set 10 04/22/24, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56473

  9. Benjamin Franzke rebased onto patch set 11 V +1 04/22/24, 13:53

  10. core-ci voted on patch set 11 V +1 04/22/24, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56492

  11. Benjamin Franzke uploaded patch set 12 V +1 04/22/24, 14:08

  12. Benjamin Franzke uploaded patch set 13 04/22/24, 14:49

  13. Benjamin Franzke uploaded patch set 14 04/22/24, 15:18

  14. core-ci voted on patch set 14 V -1 04/22/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56495

  15. Benjamin Franzke uploaded patch set 15 V -1 04/22/24, 15:25

  16. core-ci voted on patch set 15 V +1 04/22/24, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56497

  17. Benjamin Franzke uploaded patch set 16 V +1 04/24/24, 06:50

  18. core-ci voted on patch set 16 V +1 04/24/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56638

  19. Benni Mack voted on patch set 16 CR +1 V +1 04/24/24, 21:37

  20. Stefan Bürk voted on patch set 16 CR +1 04/25/24, 15:48

  21. core-ci commented on patch set 16 04/25/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56711

  22. Stefan Bürk voted on patch set 16 V +1 04/25/24, 22:07

  23. Benjamin Franzke voted on patch set 16 CR +2 V +2 04/26/24, 07:07

  24. Benjamin Franzke merged patch set 17 04/26/24, 07:09

  25. Anja Leichsenring commented on patch set 17 04/26/24, 07:22

    BackendController.php:233 Unresolved

    third parameter should be true, false is the default