Review main Merged

83706[BUGFIX] Add missing template record information

Oli Bartsch CR +2 V +2 Easy +9 −0 updated 04/10/24, 10:53

Commit message

Provide the missing template record variable,
used in the info box of the constant editor,
in case no template is selected (special UID -1).
Happens for sites using site sets and therefore
having no sys_template record to be selected.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1518

  1. Oli Bartsch uploaded patch set 1 04/08/24, 13:36

  2. core-ci voted on patch set 1 V -1 04/08/24, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55563

  3. Andreas Kienast commented on patch set 1 04/08/24, 13:47

    ConstantEditorController.php:138

    We could `break` here as well.
  4. Oli Bartsch uploaded patch set 2 V -1 04/08/24, 14:10

  5. Oli Bartsch commented on patch set 2 04/08/24, 14:10

    ConstantEditorController.php:138 Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/08/24, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55567

  7. Andreas Kienast voted on patch set 2 CR +1 04/08/24, 16:43

  8. Jörg Bösche voted on patch set 2 CR +1 04/09/24, 06:23

  9. Christian Kuhn commented on patch set 2 CR -1 04/09/24, 11:35

    i don't get it: what exactly changes here, could you elaborate a bit? maybe also in commit message? did this change with the recent patches? if so, please relate in forge and set a related in commit message. if not, please describe in more details what this change is actually about.
  10. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 04/09/24, 11:42

  11. Oli Bartsch commented on patch set 3 04/09/24, 11:42

    Reply

    Updated the message and linked the corresponding issue.
  12. core-ci voted on patch set 3 V +1 04/09/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55602

  13. Christian Kuhn commented on patch set 3 CR +1 V +1 04/09/24, 12:17

    Reply

    Done
  14. Jörg Bösche voted on patch set 3 CR +1 04/09/24, 12:20

  15. Jasmina Ließmann voted on patch set 3 V +1 04/09/24, 19:05

  16. Jasmina Ließmann voted on patch set 3 CR +1 04/09/24, 19:13

  17. Andreas Kienast voted on patch set 3 CR +2 V +2 04/10/24, 10:53

  18. Andreas Kienast merged patch set 4 04/10/24, 10:53