Review main Merged

83708[FEATURE] Provide PageInformation in PAGEVIEW cObject

Oli Bartsch CR +2 V +2 Normal +139 −9 updated 04/21/24, 19:05

Commit message

This extends the PAGEVIEW content object to provide
not only the page record, but the full Page Information
object, which among others contains the page record, the
rootline and additionally also the Page Layout object.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Lisa Kreitz +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Lisa Kreitz +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 3747

Show 1822 earlier messages
  1. Oli Bartsch uploaded patch set 1 04/08/24, 14:37

  2. Andreas Kienast commented on patch set 1 04/08/24, 14:41

    Not sure here whether this qualifies as a new feature. IMO [TASK] is sufficient.
  3. core-ci voted on patch set 1 V +1 04/08/24, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55569

  4. Oliver Klee commented on patch set 1 04/08/24, 14:47

    Can we cover this with a test?
  5. Andreas Kienast voted on patch set 1 CR +1 04/09/24, 07:51

  6. Oli Bartsch commented on patch set 1 04/09/24, 10:58

    Reply

    What kind of test do you think about?
  7. Oliver Klee commented on patch set 1 04/09/24, 11:04

    Reply

    Maybe a functional test that renders a page view template that uses the new variable.
  8. Stefan Bürk uploaded patch set 2 CR +1 V +1 04/09/24, 22:45

  9. Stefan Bürk commented on patch set 2 04/09/24, 22:47

    Reply

    Added assertion for layout identifier to existing tests, hope that is fine for you @typo3-coding@oliverklee.de - additionally added test for the reserved variable name exception.
  10. Stefan Bürk uploaded patch set 3 04/09/24, 22:48

  11. core-ci voted on patch set 2 V +1 04/09/24, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55643

  12. core-ci voted on patch set 3 V +1 04/09/24, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55644

  13. Stefan Bürk voted on patch set 3 CR +1 V +1 04/09/24, 22:54

  14. Georg Ringer commented on patch set 3 CR -1 04/10/24, 06:02

    Feature-103504-NewContentObjectPageView.rst:48

    can we leave some more information as most integrators just are used to the layout identifier and know *nothing* about the page layout object

    Feature-103504-NewContentObjectPageView.rst:157

    as those are not many, can we please list all of those?
  15. Oliver Klee commented on patch set 3 V +1 04/10/24, 07:12

    Reply

    Looks good, thanks for providing the new tests!
  16. Andreas Kienast commented on patch set 3 04/10/24, 08:11

    Feature-103504-NewContentObjectPageView.rst:157 Reply

    Those are literally listed starting at line 44. ;)
  17. Georg Ringer voted on patch set 3 CR 0 04/10/24, 08:18

  18. Andreas Kienast commented on patch set 3 04/18/24, 07:20

    PageViewContentObjectTest.php:92

    I assume you mean "stub"?
  19. Oli Bartsch uploaded patch set 4 CR +1 V +1 04/18/24, 07:29

  20. Oli Bartsch commented on patch set 4 04/18/24, 07:30

    Feature-103504-NewContentObjectPageView.rst:48 Reply

    Done

    PageViewContentObjectTest.php:92 Reply

    Done
  21. core-ci voted on patch set 4 V +1 04/18/24, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56226

  22. Andreas Kienast voted on patch set 4 CR +1 V +1 04/18/24, 07:35

  1. Stefan Bürk voted on patch set 4 CR +1 V +1 04/18/24, 07:54

  2. Oliver Klee voted on patch set 4 V +1 04/18/24, 09:45

  3. Benni Mack commented on patch set 4 CR -1 04/18/24, 13:01

    I suggest to add the pagelayout object to the pageinformation object and add that one to the view. this way we can utilize more things (e.g. rootline for breadcrumbs) and not polluting the main variables with separate options
  4. Oli Bartsch uploaded patch set 5 CR +1 V +1 04/19/24, 07:27

  5. Oli Bartsch uploaded patch set 6 04/19/24, 07:32

  6. Oliver Klee voted on patch set 6 V +1 04/19/24, 07:33

  7. core-ci voted on patch set 5 V -1 04/19/24, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56299

  8. core-ci voted on patch set 6 V -1 04/19/24, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56304

  9. Oli Bartsch uploaded patch set 7 V +1 04/19/24, 09:24

  10. Oli Bartsch uploaded patch set 8 04/19/24, 09:31

  11. core-ci voted on patch set 7 V +1 04/19/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56319

  12. core-ci voted on patch set 8 V +1 04/19/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56323

  13. Stefan Bürk commented on patch set 8 04/19/24, 09:57

    PageLayoutResolver.php:62

    Would it not be enough to use a NullSite here instead and not doing a early return ?
  14. Oli Bartsch uploaded patch set 9 V +1 04/19/24, 10:05

  15. Oli Bartsch commented on patch set 9 04/19/24, 10:05

    PageLayoutResolver.php:62 Reply

    Done
  16. core-ci voted on patch set 9 V +1 04/19/24, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56326

  17. Benni Mack commented on patch set 9 04/19/24, 22:35

    This change means, that we now need to access {page.pageRecord.title} to get the page title of the current page. How about using {pageContext} as variable name?
  18. Stefan Bürk commented on patch set 9 04/20/24, 09:19

    PageInformation.php:252

    Shouldn't the return type be nullable ? If page layout is not set, calling the getter will throw a return type exception/error, which may not be obvious in some usages. And without a `has()` method it could not be checked beforehand.
  19. Lisa Kreitz uploaded patch set 10 V +1 04/20/24, 19:46

  20. Lisa Kreitz commented on patch set 10 CR +1 V +1 04/20/24, 19:49

    Tested by creating a breadcrumb menu. Nice to have!

    PageInformation.php:252 Reply

    Done
  21. core-ci voted on patch set 10 V +1 04/20/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56393

  22. Benni Mack voted on patch set 10 CR +1 V +1 04/20/24, 19:53

  23. Stefan Bürk voted on patch set 10 CR +1 V +1 04/21/24, 01:54

  24. Georg Ringer voted on patch set 10 CR +2 V +2 04/21/24, 19:05

  25. Georg Ringer merged patch set 11 04/21/24, 19:05