Review main Merged

83772[BUGFIX] Add missing `resname` attribute to dashboard xlf files

Andreas Kienast CR +2 V +2 Normal +70 −70 updated 04/12/24, 19:16

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Nedbal +1
    • Oliver Klee +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Nedbal +1
    • Oliver Klee +1
    • Willi Wehmeier +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 910

  1. Andreas Kienast uploaded patch set 1 04/12/24, 10:18

  2. core-ci voted on patch set 1 V +1 04/12/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55851

  3. Willi Wehmeier voted on patch set 1 CR +1 V +1 04/12/24, 10:26

  4. Oliver Klee voted on patch set 1 CR +1 V +1 04/12/24, 10:29

  5. Andreas Nedbal voted on patch set 1 CR +1 V +1 04/12/24, 11:08

  6. Georg Ringer voted on patch set 1 CR +2 V +2 04/12/24, 11:14

  7. Georg Ringer merged patch set 2 04/12/24, 11:14

  8. Ayke Halder commented on patch set 2 04/12/24, 12:17

    locallang.xlf:12 Unresolved

    We missed that one! It must be `resname` but is `resnamr`
  9. Jasmina Ließmann commented on patch set 2 04/12/24, 19:00

    locallang.xlf:91

    This one is duplicated with the line above and should be 'widgets.documentation.gettingStarted.content.label'.
  10. Jasmina Ließmann commented on patch set 2 04/12/24, 19:16

    locallang.xlf:91 Reply