Review main Merged

83841[BUGFIX] Add missing identifier for additional filemounts

Oli Bartsch CR +2 V +2 Easy +3 −2 updated 04/19/24, 05:41

Commit message

Using `options.folderTree.altElementBrowserMountPoints`
it's possible to add additional mount points to the
file / folder tree. Adding such entries does now
properly work by adding the missing `identifier` key,
which is required to add those entries to a storage
in `StoragePermissionAspect`.

Additionally, null coalescing operators are added
at two places to prevent undefined array key errors.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/17/24, 08:38

  2. core-ci voted on patch set 1 V +1 04/17/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56131

  3. Benni Mack voted on patch set 1 CR +1 V +1 04/18/24, 21:33

  4. Georg Ringer voted on patch set 1 CR +2 V +2 04/19/24, 05:41

  5. Georg Ringer merged patch set 2 04/19/24, 05:41