Review main Merged

83921[TASK] Format file size and datetime values in IS backend module

Jasmina Ließmann CR +2 V +2 Easy +11 −1 updated 04/18/24, 13:15

Commit message

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Jasmina Ließmann uploaded patch set 1 04/18/24, 12:42

  2. Jasmina Ließmann updated the commit message in patch set 2 04/18/24, 12:43

  3. core-ci voted on patch set 1 V +1 04/18/24, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56260

  4. core-ci voted on patch set 2 V +1 04/18/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56262

  5. Christian Kuhn commented on patch set 2 CR +1 V +1 04/18/24, 12:52

    StatisticDetails.html:21

    not a beauty. but well ... keep it for now.
  6. Christian Kuhn commented on patch set 2 04/18/24, 12:54

    StatisticDetails.html:21 Reply

    I think in the end, we'll end up with removing the f:for and then handle each phash field one by one to include better descriptions instead of the plain field names along the way.
  7. Christian Kuhn commented on patch set 2 04/18/24, 12:55

    StatisticDetails.html:21 Reply

    let's do a revamp of the main table in a dedicated patch, and keep that solution as is for now?!
  8. Jasmina Ließmann commented on patch set 2 04/18/24, 12:55

    StatisticDetails.html:21 Reply

    Ack
  9. Stefan Bürk commented on patch set 2 CR +1 V +1 04/18/24, 13:07

    StatisticDetails.html:21 Reply

    ack.
  10. Jasmina Ließmann voted on patch set 2 CR +2 V +2 04/18/24, 13:15

  11. Jasmina Ließmann merged patch set 3 04/18/24, 13:15