Review main Merged

83951[TASK] Remove non-translated label for site config creation button

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/23/24, 20:48

Commit message

Since the button to create a new site configuration
is already descriptive the non-translated title
attribute is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 04/22/24, 08:45

  2. core-ci voted on patch set 1 V +1 04/22/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56479

  3. Benjamin Franzke commented on patch set 1 CR -1 04/22/24, 10:07

    The button is already descriptive, why do you see a need for a `title` attribute? Argumentation against placing redundant information without providing any additional information: https://www.accede-web.com/en/guidelines/html-css/links-buttons/dont-use-the-aria-label-ortitle-attributes-on-links-and-buttons-that-are-already-explicit/ > Don’t use the aria-label or title attributes on links and buttons that are already explicit I think the button label is actually too long, it would be a good title, but the label should be shorter, maybe with some text around. I have no direct idea/concept, but this interface should ideally be reworked – changing the `title` attribute does not provide any advantage in this case IMO.
  4. Oli Bartsch commented on patch set 1 04/23/24, 06:58

    Reply

    I actually don't see the need for the title attribute. Just stumbled upon this and noticed that a non-translated string was used. However, we can omit the attribute altogether.
  5. Oli Bartsch uploaded patch set 2 CR -1 V +1 04/23/24, 07:02

  6. core-ci voted on patch set 2 V +1 04/23/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56544

  7. Oliver Klee voted on patch set 2 CR +1 04/23/24, 07:40

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 04/23/24, 07:58

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 04/23/24, 09:02

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 04/23/24, 20:47

  11. Oli Bartsch merged patch set 3 04/23/24, 20:48