83953[BUGFIX] Keep empty attributes in RTEHtmlParser
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1619
-
Oli Bartsch uploaded patch set 1 04/22/24, 11:46
-
core-ci voted on patch set 1 V +1 04/22/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56486
-
Andreas Kienast updated the commit message in patch set 2
V +104/22/24, 12:59 -
Benni Mack commented on patch set 2 04/22/24, 13:02
Can you check if we also need adaptions in lib.parseFunc to also allow empty attributes? IIRC this was also removed there when I checked the last time... -
core-ci voted on patch set 2 V +1 04/22/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56490
-
Timo Webler commented on patch set 2 04/22/24, 13:39
Reply
Yes is needed. See https://forge.typo3.org/issues/103698#note-3 -
Oli Bartsch commented on patch set 2 04/22/24, 14:48
Reply
The diff you posted seems to be for v11, while you added the bug report for v12. Could you please check whether the diff also applies for current versions? -
Oli Bartsch uploaded patch set 3
V +104/22/24, 14:59 -
Oli Bartsch commented on patch set 3 04/22/24, 15:01
Reply
Oke, already found the corresponding place. -
Simon Schaufelberger commented on patch set 3 04/22/24, 17:39
RteHtmlParserTest.php:762asas? -
Oli Bartsch uploaded patch set 4 04/22/24, 20:06
-
Oli Bartsch commented on patch set 4 04/22/24, 20:09
RteHtmlParserTest.php:762ReplySometimes, when I'm frustrated about failing test, I rename those functions to express my frustration. However, I usually do not commit such state. 😉 -
core-ci voted on patch set 4 V +1 04/22/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56509
-
Benni Mack voted on patch set 4 CR +1 V +1 04/22/24, 20:12
-
Simon Schaufelberger voted on patch set 4 CR +1 04/22/24, 21:08
-
Stefan Bürk voted on patch set 4 CR +1 V +1 04/22/24, 22:18
-
Oliver Klee voted on patch set 4 CR +1 V +1 04/22/24, 22:22
-
Oli Bartsch voted on patch set 4 CR +2 V +2 04/23/24, 06:55
-
Oli Bartsch merged patch set 5 04/23/24, 06:56