Review main Merged

83953[BUGFIX] Keep empty attributes in RTEHtmlParser

Oli Bartsch CR +2 V +2 Easy +33 −2 updated 04/23/24, 06:56

Commit message

To allow the use of "empty" attributes, such
as `download` in the CKeditor, the RTEHtmlParser
does now keep such attributes while processing.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1619

  1. Oli Bartsch uploaded patch set 1 04/22/24, 11:46

  2. core-ci voted on patch set 1 V +1 04/22/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56486

  3. Andreas Kienast updated the commit message in patch set 2 V +1 04/22/24, 12:59

  4. Benni Mack commented on patch set 2 04/22/24, 13:02

    Can you check if we also need adaptions in lib.parseFunc to also allow empty attributes? IIRC this was also removed there when I checked the last time...
  5. core-ci voted on patch set 2 V +1 04/22/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56490

  6. Timo Webler commented on patch set 2 04/22/24, 13:39

  7. Oli Bartsch commented on patch set 2 04/22/24, 14:48

    Reply

    The diff you posted seems to be for v11, while you added the bug report for v12. Could you please check whether the diff also applies for current versions?
  8. Oli Bartsch uploaded patch set 3 V +1 04/22/24, 14:59

  9. Oli Bartsch commented on patch set 3 04/22/24, 15:01

    Reply

    Oke, already found the corresponding place.
  10. Simon Schaufelberger commented on patch set 3 04/22/24, 17:39

    RteHtmlParserTest.php:762

    asas?
  11. Oli Bartsch uploaded patch set 4 04/22/24, 20:06

  12. Oli Bartsch commented on patch set 4 04/22/24, 20:09

    RteHtmlParserTest.php:762 Reply

    Sometimes, when I'm frustrated about failing test, I rename those functions to express my frustration. However, I usually do not commit such state. 😉
  13. core-ci voted on patch set 4 V +1 04/22/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56509

  14. Benni Mack voted on patch set 4 CR +1 V +1 04/22/24, 20:12

  15. Simon Schaufelberger voted on patch set 4 CR +1 04/22/24, 21:08

  16. Stefan Bürk voted on patch set 4 CR +1 V +1 04/22/24, 22:18

  17. Oliver Klee voted on patch set 4 CR +1 V +1 04/22/24, 22:22

  18. Oli Bartsch voted on patch set 4 CR +2 V +2 04/23/24, 06:55

  19. Oli Bartsch merged patch set 5 04/23/24, 06:56