Review 12.4 Merged

84012[BUGFIX] Properly handle diff while updating meta data

Christian Kuhn CR +2 V +2 Normal +56 −1 updated 04/23/24, 18:59

Commit message

The existing solution using `array_diff` did not work, as it only
respects values, not a combination with keys.

Given an existing record with some empty values would prevent unsetting
another value with an empty. The same would apply for setting another
value to an existing value.

That's why we change to `array_diff_assoc`, which handles proper diff of
value in combination with key.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 04/23/24, 18:41

  2. core-ci voted on patch set 1 V +1 04/23/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56605

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 04/23/24, 18:59

  4. Christian Kuhn merged patch set 2 04/23/24, 18:59