Review main Merged

84018[BUGFIX] Omit wrong value on inserting record

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/10/24, 16:37

Commit message

When inserting a record via the element
browser, the value argument needs either
to be formatted manually or left empty,
allowing the element browser to format
the identifier automatically.

By omitting the value in the `PageBrowser`
module, the value is now correctly formatted
by the element browser to "pages_<uid>".

This makes the "node-action" usable for
TCA group fields, which allow more than
one record type.

The same logic is also used by the
`BrowseDatabase` module, which also
omits the value argument.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Oli Bartsch uploaded patch set 1 04/24/24, 15:37

  2. core-ci voted on patch set 1 V +1 04/24/24, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56664

  3. Oli Bartsch rebased onto patch set 2 V +1 05/27/24, 09:02

  4. core-ci voted on patch set 2 V +1 05/27/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58332

  5. Oli Bartsch rebased onto patch set 3 V +1 06/10/24, 09:47

  6. core-ci voted on patch set 3 V +1 06/10/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58987

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 06/10/24, 13:44

  8. Stefan Bürk voted on patch set 3 CR +1 06/10/24, 15:47

  9. Stefan Bürk voted on patch set 3 V +1 06/10/24, 15:52

  10. Oli Bartsch voted on patch set 3 CR +2 V +2 06/10/24, 16:37

  11. Oli Bartsch merged patch set 4 06/10/24, 16:37