Review main Merged

84023[TASK] Merge word lists in EXT:indexed_search statisticDetailsAction

Jasmina Ließmann CR +2 V +2 Hard +146 −109 updated 06/05/24, 14:29

Commit message

In single result view of the "Indexing" backend module, the words
found on the page are listed in three tables, each sorted by count,
frequency and name.
This patch removes the tables "Words by top count" and "Words by
frequency" and extends the remaining table to sort by table columns
"Word", "Word count" and "Frequency".

If no words were found, an info box is now displayed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1627

Show 12 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/25/24, 18:49

  2. core-ci voted on patch set 1 V +1 04/25/24, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56712

  1. Jasmina Ließmann uploaded patch set 2 V +1 04/25/24, 18:59

  2. core-ci voted on patch set 2 V +1 04/25/24, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56713

  3. Jasmina Ließmann uploaded patch set 3 V +1 04/25/24, 19:17

  4. core-ci voted on patch set 3 V +1 04/25/24, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56714

  5. Jasmina Ließmann uploaded patch set 4 V +1 05/30/24, 10:14

  6. core-ci voted on patch set 4 V -1 05/30/24, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58480

  7. Jasmina Ließmann uploaded patch set 5 V -1 05/30/24, 10:18

  8. core-ci voted on patch set 5 V -1 05/30/24, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58483

  9. Jasmina Ließmann updated the commit message in patch set 6 V -1 05/30/24, 10:28

  10. core-ci voted on patch set 6 V -1 05/30/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58486

  11. Jasmina Ließmann uploaded patch set 7 V -1 05/30/24, 10:35

  12. core-ci voted on patch set 7 V +1 05/30/24, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58487

  13. Jasmina Ließmann uploaded patch set 8 V +1 05/30/24, 10:50

  14. core-ci voted on patch set 8 V +1 05/30/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58488

  15. Jasmina Ließmann uploaded patch set 9 V +1 05/30/24, 11:25

  16. core-ci voted on patch set 9 V +1 05/30/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58489

  17. Benni Mack voted on patch set 9 CR +1 06/01/24, 21:27

  18. Jasmina Ließmann updated the commit message in patch set 10 CR +1 V +1 06/02/24, 16:58

  19. Jasmina Ließmann updated the commit message in patch set 11 06/02/24, 17:00

  20. core-ci voted on patch set 10 V +1 06/02/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58593

  21. core-ci voted on patch set 11 V +1 06/02/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58594

  22. Benni Mack voted on patch set 11 CR +1 06/02/24, 19:10

  23. Georg Ringer voted on patch set 11 CR +1 V +1 06/02/24, 20:43

  24. Christian Kuhn commented on patch set 11 CR +2 V +2 06/05/24, 14:29

    much better!
  25. Christian Kuhn merged patch set 12 06/05/24, 14:29