Review main Merged

84080[TASK] Reorganize backend group form sections inside tabs

Marcin Sągol CR +2 V +2 Easy +14 −9 updated 06/11/24, 19:02

Commit message

This patch reorganizes sections within the tabs of the backend user
group form:

- The sections 'groupMods', 'availableWidgets', 'mfa_providers',
and 'custom_options' were moved to a newly created tab named
'Module Permissions'.
- The 'pagetypes_select' section was moved to the top to avoid
splitting the closely related 'tables_select', 'tables_modify', and
'non_exclude_fields' sections.
- The 'Access Rights' tab was renamed to 'Record Permissions'.
- The 'Access Rights' tab in the backend user form was renamed
to 'Permissions'.
- The purpose of renaming these tabs is to distinguish them
and their content from the more general 'Access' tab,
which handles access and visibility for given records.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Thomas Hohn +1
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Manuel Selbach +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1822

  1. Marcin Sągol uploaded patch set 1 04/29/24, 08:53

  2. core-ci voted on patch set 1 V -1 04/29/24, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56958

  3. Georg Ringer commented on patch set 1 04/29/24, 11:34

    don't do that for v12 please
  4. Georg Ringer voted on patch set 1 CR -1 04/29/24, 11:34

  5. Marcin Sągol uploaded patch set 2 CR -1 V -1 04/29/24, 13:09

  6. core-ci voted on patch set 2 V +1 04/29/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56967

  7. Marcin Sągol commented on patch set 2 04/29/24, 13:18

    Reply

    Fixed.
  8. Riccardo De Contardi voted on patch set 2 V +1 05/01/24, 13:50

  9. Guido Schmechel commented on patch set 2 05/02/24, 16:10

    "sections"
  10. Benni Mack updated the commit message in patch set 3 V +1 05/13/24, 20:14

  11. Benni Mack commented on patch set 3 05/13/24, 20:14

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 05/13/24, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57646

  13. Andreas Kienast voted on patch set 3 CR +1 05/14/24, 06:13

  14. Marcin Sągol rebased onto patch set 4 CR +1 V +1 06/03/24, 08:48

  15. core-ci voted on patch set 4 V +1 06/03/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58613

  16. Thomas Hohn voted on patch set 4 CR +1 06/03/24, 09:18

  17. Manuel Selbach voted on patch set 4 CR +1 06/03/24, 09:53

  18. Guido Schmechel voted on patch set 4 CR +1 V +1 06/05/24, 10:19

  19. Garvin Hicking voted on patch set 4 CR +1 V +1 06/05/24, 10:34

  20. Michael Telgkamp voted on patch set 4 CR +1 V +1 06/10/24, 11:19

  21. Georg Ringer voted on patch set 4 CR +2 V +2 06/11/24, 19:02

  22. Georg Ringer merged patch set 5 06/11/24, 19:02