Review main Merged

84100[TASK] Add possibility to create HashValue from actual payload

Oliver Hader CR +2 V +2 Easy +15 −3 updated 05/01/24, 05:38

Commit message

The new factory method `HashValue::hash('test')` creates the
hash from the raw payload `'test'`. This is a simpler shortcut
for using `HashValue::create(hash('sha256', 'test', true))`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 04/30/24, 20:34

  2. core-ci voted on patch set 1 V +1 04/30/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57021

  3. Markus Klein voted on patch set 1 CR +1 04/30/24, 20:51

  4. Benni Mack voted on patch set 1 CR +1 V +1 04/30/24, 21:55

  5. Georg Ringer voted on patch set 1 CR +2 V +2 05/01/24, 05:38

  6. Georg Ringer merged patch set 2 05/01/24, 05:38