Review main Merged

84101[TASK] Fix error message for PAGEVIEW template

Lina Wolf CR +2 V +2 Easy +5 −2 updated 05/03/24, 07:56

Commit message

The $pageLayoutName is treated as 'action' and
is passed through ucfirst in
TYPO3Fluid\Fluid\View\TemplatePaths::
resolveTemplateFileForControllerAndActionAndFormat

Therefore if a backend layout starts with a lowercase name,
then the template name still has to start with a uppercase name.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Lina Wolf uploaded patch set 1 05/01/24, 14:02

  2. core-ci voted on patch set 1 V +1 05/01/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57047

  3. Nikita Hovratov commented on patch set 1 05/01/24, 17:17

    PageViewContentObject.php:115

    Did you intend to show the alternative uppercase "Pages" here?

    PageViewContentObject.php:115

    Looks like white-space is missing before "or".

    PageViewContentObject.php:116

    Could you change "templateRootPaths" to just "paths" here as drive-by, please? This got changed last-minute in review.
  4. Lina Wolf uploaded patch set 2 V +1 05/01/24, 17:32

  5. Lina Wolf commented on patch set 2 05/01/24, 17:32

    PageViewContentObject.php:115 Reply

    Done

    PageViewContentObject.php:115 Reply

    Done

    PageViewContentObject.php:116 Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/01/24, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57050

  7. Nikita Hovratov voted on patch set 2 CR +1 05/01/24, 17:54

  8. Nikita Hovratov voted on patch set 2 V +1 05/01/24, 17:56

  9. Benjamin Franzke commented on patch set 2 05/02/24, 06:03

    PageViewContentObject.php:114

    Since the implementation above prefers `pages` over `Pages` we should probably list the possible paths in that order as well.
  10. Lina Wolf commented on patch set 2 05/02/24, 06:06

    PageViewContentObject.php:114 Reply

    According to the changelog entry "In order to reduce the burden for integrators, the folder names for "pages", "layouts" and "partials" can start with a lowercase or an uppercase letter." Lowercase was added and ucfirst is used in all the examples in the changelog entry
  11. Benjamin Franzke uploaded patch set 3 CR +1 V +1 05/03/24, 07:17

  12. Benjamin Franzke commented on patch set 3 05/03/24, 07:17

    PageViewContentObject.php:114 Reply

    Acknowledged
  13. core-ci voted on patch set 3 V +1 05/03/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57157

  14. Nikita Hovratov voted on patch set 3 CR +1 05/03/24, 07:47

  15. Nikita Hovratov voted on patch set 3 CR +2 V +2 05/03/24, 07:56

  16. Nikita Hovratov merged patch set 4 05/03/24, 07:56