Review main Merged

84150[TASK] Add unicode license file next to .tbl files

Willi Wehmeier CR +2 V +2 Easy +39 −0 updated 05/06/24, 15:18

Commit message

The folder containing the charset conversion table files
should have the unicode license.txt file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Willi Wehmeier uploaded patch set 1 05/06/24, 13:53

  2. core-ci voted on patch set 1 V +1 05/06/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57287

  3. Willi Wehmeier uploaded patch set 2 V +1 05/06/24, 13:59

  4. Andreas Kienast commented on patch set 2 CR -2 05/06/24, 14:01

    Thanks for this patch. I'm blocking this for now as legal stuff might be affected here (e.g. whether this file needs to be present in any supported TYPO3 version).
  5. core-ci voted on patch set 2 V +1 05/06/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57288

  6. Benni Mack commented on patch set 2 05/06/24, 14:12

    Hey Willi, can you also share where you got this License file from?
  7. Willi Wehmeier commented on patch set 2 05/06/24, 14:15

    Reply

    Sure, it's the content of this file: https://unicode.org/license.txt
  8. Andreas Kienast updated the commit message in patch set 3 V +1 05/06/24, 14:51

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. Andreas Kienast voted on patch set 3 CR +1 V +1 05/06/24, 14:51

  10. core-ci voted on patch set 3 V +1 05/06/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57294

  11. Benni Mack voted on patch set 3 CR +2 V +2 05/06/24, 15:18

  12. Benni Mack merged patch set 4 05/06/24, 15:18