84185[BUGFIX] Trigger cache flush on siteconfiguration changes
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+6 −1
- typo3/sysext/core/Classes/ServiceProvider.php+1 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+3 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+2 −0
Review log 1317
-
Willi Wehmeier uploaded patch set 1 05/10/24, 06:09
-
core-ci voted on patch set 1 V +1 05/10/24, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57473
-
Oliver Klee voted on patch set 1 CR +1 05/10/24, 08:05
-
Benjamin Franzke uploaded patch set 2
CR +1V +105/10/24, 09:05 -
core-ci voted on patch set 2 V -1 05/10/24, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57475
-
Benjamin Franzke uploaded patch set 3
CR +1V +105/10/24, 09:58 -
core-ci voted on patch set 3 V +1 05/10/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57477
-
Jörg Bösche voted on patch set 3 CR +1 05/10/24, 10:53
-
Patrick Schriner voted on patch set 3 CR +1 V +1 05/13/24, 09:29
-
Christian Kuhn commented on patch set 3 05/20/24, 11:17
-
Willi Wehmeier commented on patch set 3 05/21/24, 05:50
TypoScriptFrontendController.php:349ReplyThe question (at least I think this is the point of matter) is if it's okay to generally flush all caches in a multi site instance regardless whether the change does affect only one site. Sure, performance wise flushing system and pages is much faster than iterating over all caches and deleting tags but I think we should affect sites without siteconfig changes as little as possible. -
Benjamin Franzke commented on patch set 3 05/21/24, 06:04
TypoScriptFrontendController.php:349Reply Unresolved> i wonder if we could just fully flush pages cache instead, or flush caches by group? This is what patchset 1 did and I think that's not a good idea to knowingly flush too much. We have been holding cache-tag innovation for too long – https://review.typo3.org/c/Packages/TYPO3.CMS/+/81801 – therefore I took the momentum and wanted to actually use them for usecases where they are really useful. I understand that feels brave for a 12 backport, but it makes sense to properly flush (frontend) caches from data sources that are made available by the core to frontend rendering (e.g. via getData). I also understand the concerns to add new cache tags and I actually expected that response (and waited for that before an early merge) but I hope we can agree to do this nonetheless, as we had patches that tried to improve any obstacles from too many cache tags. Actally I think this additional cache tag will not hurt, as this is still a scalar cache tag growth (2*n) and not multidimensional (n*m) per page. > it introduces a convention for this tag name on all caches, other caches should then use and not misuse. Yes, I did that on purpose. If other (sub-caches) are derived from site configuration, then it's fine for them to use the same tag and allow proper clearing on change. (I'd do the same with the `pageId_*` convention, if I had a sub-cache) -
Benni Mack updated the commit message in patch set 4
CR +1V +110/18/24, 13:30 -
core-ci voted on patch set 4 V -1 10/18/24, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67979
-
Benni Mack commented on patch set 4 12/11/24, 11:46
please either abandon or revive this patch now that the new CacheTag API is in place. Otherwise I will abandon this change in 2 weeks. -
Oliver Klee wrote 12/11/24, 13:41
Removed reviewer Oliver Klee. -
Benni Mack abandoned the change 04/02/25, 12:15
as mentioned, abandoning this change for the time being
TypoScriptFrontendController.php:349