Review main Merged

84232[BUGFIX] Correct examples for expression builder methods in changelog

TYPO3com CR +2 V +2 Easy +36 −8 updated 05/13/24, 20:16

Commit message

->expr() must be executed on QueryBuilder, not on Connection

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 914

  1. TYPO3com uploaded patch set 1 05/13/24, 15:19

  2. core-ci voted on patch set 1 V +1 05/13/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57625

  3. Chris Müller commented on patch set 1 CR -1 05/13/24, 15:46

    Feature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:230

    self::TABLE_NAME is not defined here, use a distinct table name (also changes below).
  4. Stefan Bürk uploaded patch set 2 CR -1 V +1 05/13/24, 16:09

  5. Stefan Bürk uploaded patch set 3 05/13/24, 16:14

  6. core-ci voted on patch set 2 V +1 05/13/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57630

  7. core-ci voted on patch set 3 V +1 05/13/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57631

  8. Chris Müller updated the commit message in patch set 4 V +1 05/13/24, 16:41

  9. Chris Müller commented on patch set 4 05/13/24, 16:41

    Feature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst:230 Reply

    Done
  10. core-ci voted on patch set 4 V +1 05/13/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57635

  11. Chris Müller voted on patch set 4 CR +1 V +1 05/13/24, 18:02

  12. Benni Mack voted on patch set 4 CR +1 V +1 05/13/24, 20:14

  13. Stefan Bürk voted on patch set 4 CR +2 V +2 05/13/24, 20:16

  14. Stefan Bürk merged patch set 5 05/13/24, 20:16