Review main Merged

84253[BUGFIX] Avoid double-encoding of delete label

Andreas Kienast CR +2 V +2 Easy +16 −12 updated 05/14/24, 14:41

Commit message

The label for the delete action was encoded twice, leading to text
issues in case special characters are involved. This commit makes use of
`GeneralUtility::implodeAttributes()` to solve this issue properly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Andreas Kienast uploaded patch set 1 05/14/24, 07:30

  2. Andreas Kienast uploaded patch set 2 05/14/24, 07:35

  3. core-ci voted on patch set 1 V -1 05/14/24, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57681

  4. core-ci voted on patch set 2 V +1 05/14/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57682

  5. Benjamin Franzke voted on patch set 2 CR +1 05/14/24, 09:27

  6. Benjamin Franzke voted on patch set 2 V +1 05/14/24, 09:28

  7. Benni Mack voted on patch set 2 CR +1 V +1 05/14/24, 11:56

  8. Oliver Hader voted on patch set 2 CR +1 05/14/24, 13:06

  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 05/14/24, 13:45

  10. Andreas Kienast uploaded patch set 4 05/14/24, 13:55

  11. Benjamin Franzke commented on patch set 3 05/14/24, 13:55

    DatabaseRecordList.php:1727

    `true, true` was fine for `data-l10parent` :D
  12. Benjamin Franzke voted on patch set 4 CR +1 V +1 05/14/24, 13:55

  13. core-ci voted on patch set 3 V +1 05/14/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57715

  14. core-ci voted on patch set 4 V +1 05/14/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57716

  15. Benni Mack voted on patch set 4 CR +1 V +1 05/14/24, 14:38

  16. Andreas Kienast voted on patch set 4 CR +2 V +2 05/14/24, 14:40

  17. Andreas Kienast merged patch set 5 05/14/24, 14:41