Review main Merged

84313[TASK] Remove superfluous typecast in TSFE

Torben Hansen CR +2 V +2 Easy +1 −4 updated 05/20/24, 20:14

Commit message

This change removes a superfluous typecast in
`TypoScriptFrontendController`.

Additionally, the function's doc comment has been revised
and the `@param` comment has been removed, since the
function parameter is self-explaining.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Torben Hansen uploaded patch set 1 05/19/24, 11:43

  2. core-ci voted on patch set 1 V +1 05/19/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57913

  3. Torben Hansen uploaded patch set 2 V +1 05/19/24, 11:53

  4. core-ci voted on patch set 2 V +1 05/19/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57914

  5. Oliver Klee updated the commit message in patch set 3 V +1 05/19/24, 13:31

  6. Oliver Klee voted on patch set 3 CR +1 V +1 05/19/24, 13:31

  7. core-ci voted on patch set 3 V +1 05/19/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57915

  8. Chris Müller voted on patch set 3 CR +1 V +1 05/19/24, 14:03

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 05/20/24, 20:14

  10. Christian Kuhn merged patch set 4 05/20/24, 20:14