Review main Merged

84320[BUGFIX] Avoid data array to be null in CObjectViewHelper

Mogens Fiebrandt CR +2 V +2 Easy +1 −1 updated 05/21/24, 08:16

Commit message

The CObjectViewHelper didn't render IMAGE-objects with
GIFBUILDER properly.

This change avoids the data array in the renderStatic
method of the CObjectViewHelper to be null.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Mogens Fiebrandt uploaded patch set 1 05/20/24, 21:00

  2. core-ci voted on patch set 1 V +1 05/20/24, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57954

  3. Simon Schaufelberger commented on patch set 1 05/21/24, 07:28

    properly
  4. Anja Leichsenring updated the commit message in patch set 2 V +1 05/21/24, 07:37

  5. Anja Leichsenring commented on patch set 2 CR +1 V +1 05/21/24, 07:37

    nice catch, thank you for your contribution.
  6. Anja Leichsenring commented on patch set 2 05/21/24, 07:39

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 05/21/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57983

  8. Stefan Bürk voted on patch set 2 CR -1 05/21/24, 07:43

  9. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 05/21/24, 08:06

  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 05/21/24, 08:13

  11. core-ci voted on patch set 3 V +1 05/21/24, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57984

  12. Stefan Bürk commented on patch set 3 CR +2 V +2 05/21/24, 08:16

    @mogens.fiebrandt@googlemail.com thank you for this fix, nice catch !
  13. Stefan Bürk merged patch set 4 05/21/24, 08:16