Review main Merged

84333[BUGFIX] Avoid throwing away previous errors in integrity checks

Stefan Bürk CR +2 V +2 Easy +0 −1 updated 05/21/24, 12:45

Commit message

With change #103465 a couple of code integrity checks based on the
`nikic/php-parser` have been combined into one file scanning script.

The goal is to collect the information per visitor type over all
files in a internal visitor state, to output per visitor result
after all php file have been scanned. However, the visitor message
state is reset for each file with the call of `startProcessing()`
method within `AbstractPhpIntegrityChecker`, thus keeping only the
result of the last error.

This change removes the message reset from the the `startProcessing()`
method to keep all error, thus displaying all errors in one go.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 05/21/24, 09:57

  2. core-ci voted on patch set 1 V +1 05/21/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57987

  3. Anja Leichsenring updated the commit message in patch set 2 V +1 05/21/24, 11:16

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/21/24, 11:16

  5. core-ci voted on patch set 2 V +1 05/21/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57995

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 05/21/24, 12:42

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 05/21/24, 12:43

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 05/21/24, 12:44

  9. Stefan Bürk merged patch set 3 05/21/24, 12:45