Review main Merged

84343[BUGFIX] Fix return type of Query::execute()

Sascha Egerer CR +2 V +2 Easy +7 −6 updated 05/22/24, 14:31

Commit message

`\TYPO3\CMS\Extbase\Persistence\Generic\Query::execute()` has
a boolean flag to define if the result should be a raw result
without data mapping to an object. In this case a raw array
is returned and not an array with objects. The annotation
has been fixed at several places to be in sync with underlying
\Doctrine\DBAL\Result::fetchAllAssociative() return type.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Sascha Egerer uploaded patch set 1 05/22/24, 08:52

  2. core-ci voted on patch set 1 V +1 05/22/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58041

  3. Oliver Klee voted on patch set 1 CR +1 V +1 05/22/24, 11:37

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 05/22/24, 14:21

  5. core-ci voted on patch set 2 V +1 05/22/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58060

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 05/22/24, 14:29

  7. Anja Leichsenring voted on patch set 2 CR +2 V +2 05/22/24, 14:31

  8. Anja Leichsenring merged patch set 3 05/22/24, 14:31