84379[BUGFIX] Fix some styling in color picker component
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Jasmina Ließmann +1
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Jasmina Ließmann +1
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1722
-
Andreas Kienast uploaded patch set 1 05/24/24, 08:21
-
Andreas Kienast updated the commit message in patch set 2 05/24/24, 08:21
-
core-ci voted on patch set 1 V +1 05/24/24, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58137
-
core-ci voted on patch set 2 V +1 05/24/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58138
-
Andreas Kienast updated the commit message in patch set 3
V +105/28/24, 14:01 -
core-ci voted on patch set 3 V +1 05/28/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58405
-
Georg Ringer voted on patch set 3 CR +1 V +1 05/28/24, 14:24
-
Jasmina Ließmann voted on patch set 3 CR +1 V +1 05/30/24, 09:27
-
Benjamin Franzke commented on patch set 3 CR -1 05/30/24, 10:00
-
Andreas Kienast commented on patch set 3 05/30/24, 10:45
_colorpicker.scss:3ReplyIf it‘s the same color: because I didn‘t find it. -
Jasmina Ließmann commented on patch set 3 05/30/24, 19:47
_colorpicker.scss:3ReplyI haven't found it either - until now: @a.fernandez@scripting-base.de `--typo3-input-focus-border-color` uses a Sass variable from Bootstrap (see https://getbootstrap.com/docs/5.3/forms/form-control/#sass-variables) and it's indeed the same hexadecimal value. -
Benjamin Franzke commented on patch set 3 05/31/24, 05:51
_colorpicker.scss:3Replyi see, it's hard to find as it calculated via `tint-color()` by bootstrap: ``` $input-focus-border-color: tint-color($component-active-bg, 50%) !default; ``` -
Andreas Kienast uploaded patch set 4
CR +1V +105/31/24, 06:04 -
Benjamin Franzke rebased onto patch set 5 05/31/24, 06:06
-
Benjamin Franzke commented on patch set 5 05/31/24, 06:06
_colorpicker.scss:3ReplyDone -
Andreas Kienast commented on patch set 4 05/31/24, 06:07
_colorpicker.scss:3ReplyThanks for pointing this out, the custom property works just fine 👌. -
core-ci voted on patch set 4 V +1 05/31/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58516
-
core-ci voted on patch set 5 V +1 05/31/24, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58517
-
Jasmina Ließmann voted on patch set 5 CR +1 V +1 05/31/24, 06:26
-
Andreas Kienast voted on patch set 5 CR +2 V +2 05/31/24, 06:28
-
Andreas Kienast merged patch set 6 05/31/24, 06:28
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 05/31/24, 06:29
_colorpicker.scss:3