Review main Merged

84379[BUGFIX] Fix some styling in color picker component

Andreas Kienast CR +2 V +2 Easy +14 −14 updated 05/31/24, 06:29

Commit message

This commit updates some colors in the color picker component. The dark
background is removed from focussed input fields. Also, the input
styling now matches FormEngine styling.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1722

  1. Andreas Kienast uploaded patch set 1 05/24/24, 08:21

  2. Andreas Kienast updated the commit message in patch set 2 05/24/24, 08:21

  3. core-ci voted on patch set 1 V +1 05/24/24, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58137

  4. core-ci voted on patch set 2 V +1 05/24/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58138

  5. Andreas Kienast updated the commit message in patch set 3 V +1 05/28/24, 14:01

  6. core-ci voted on patch set 3 V +1 05/28/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58405

  7. Georg Ringer voted on patch set 3 CR +1 V +1 05/28/24, 14:24

  8. Jasmina Ließmann voted on patch set 3 CR +1 V +1 05/30/24, 09:27

  9. Benjamin Franzke commented on patch set 3 CR -1 05/30/24, 10:00

    _colorpicker.scss:3

    Why don't we use `--typo3-input-focus-border-color` directly (or at least indirectly) instead of defining the same color again?
  10. Andreas Kienast commented on patch set 3 05/30/24, 10:45

    _colorpicker.scss:3 Reply

    If it‘s the same color: because I didn‘t find it.
  11. Jasmina Ließmann commented on patch set 3 05/30/24, 19:47

    _colorpicker.scss:3 Reply

    I haven't found it either - until now: @a.fernandez@scripting-base.de `--typo3-input-focus-border-color` uses a Sass variable from Bootstrap (see https://getbootstrap.com/docs/5.3/forms/form-control/#sass-variables) and it's indeed the same hexadecimal value.
  12. Benjamin Franzke commented on patch set 3 05/31/24, 05:51

    _colorpicker.scss:3 Reply

    i see, it's hard to find as it calculated via `tint-color()` by bootstrap: ``` $input-focus-border-color: tint-color($component-active-bg, 50%) !default; ```
  13. Andreas Kienast uploaded patch set 4 CR +1 V +1 05/31/24, 06:04

  14. Benjamin Franzke rebased onto patch set 5 05/31/24, 06:06

  15. Benjamin Franzke commented on patch set 5 05/31/24, 06:06

    _colorpicker.scss:3 Reply

    Done
  16. Andreas Kienast commented on patch set 4 05/31/24, 06:07

    _colorpicker.scss:3 Reply

    Thanks for pointing this out, the custom property works just fine 👌.
  17. core-ci voted on patch set 4 V +1 05/31/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58516

  18. core-ci voted on patch set 5 V +1 05/31/24, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58517

  19. Jasmina Ließmann voted on patch set 5 CR +1 V +1 05/31/24, 06:26

  20. Andreas Kienast voted on patch set 5 CR +2 V +2 05/31/24, 06:28

  21. Andreas Kienast merged patch set 6 05/31/24, 06:28

  22. Benjamin Franzke voted on patch set 5 CR +2 V +2 05/31/24, 06:29