Review main Merged

84406[TASK] Use PHP attributes more often to configure DI

Christian Kuhn CR +2 V +2 Hard +134 −191 updated 05/27/24, 12:35

Commit message

Using PHP attributes to configure DI within classes
directly is more easy to understand since developers
don't need to constantly look up DI configuration
Services.yaml files, but have everything in one place.

The patch switches all classes that previously
used '@cache.xy' to get a specific cache injected
to an `Autowire` attribute.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 2033

Show 48 earlier messages
  1. Christian Kuhn uploaded patch set 1 05/26/24, 09:26

  2. Christian Kuhn uploaded patch set 2 05/26/24, 09:33

  3. Christian Kuhn uploaded patch set 3 05/26/24, 09:37

  4. core-ci voted on patch set 2 V +1 05/26/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58260

  5. core-ci voted on patch set 1 V -1 05/26/24, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58257

  6. core-ci voted on patch set 3 V +1 05/26/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58261

  7. Christian Kuhn uploaded patch set 4 V +1 05/26/24, 09:56

  8. core-ci voted on patch set 4 V +1 05/26/24, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58262

  1. Christian Kuhn uploaded patch set 5 V +1 05/26/24, 10:02

  2. core-ci voted on patch set 5 V +1 05/26/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58263

  3. Christian Kuhn uploaded patch set 6 V +1 05/26/24, 10:14

  4. core-ci voted on patch set 6 V -1 05/26/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58264

  5. Christian Kuhn uploaded patch set 7 V -1 05/26/24, 10:22

  6. core-ci voted on patch set 7 V +1 05/26/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58265

  7. Christian Kuhn uploaded patch set 8 V +1 05/26/24, 10:37

  8. core-ci voted on patch set 8 V -1 05/26/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58267

  9. Christian Kuhn uploaded patch set 9 V -1 05/26/24, 10:46

  10. core-ci voted on patch set 9 V +1 05/26/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58268

  11. Christian Kuhn uploaded patch set 10 V +1 05/26/24, 10:53

  12. core-ci voted on patch set 10 V +1 05/26/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58269

  13. Christian Kuhn uploaded patch set 11 V +1 05/26/24, 11:15

  14. Christian Kuhn uploaded patch set 12 05/26/24, 11:19

  15. core-ci voted on patch set 11 V +1 05/26/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58271

  16. core-ci voted on patch set 12 V +1 05/26/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58272

  17. Christian Kuhn uploaded patch set 13 V +1 05/26/24, 11:51

  18. Christian Kuhn commented on patch set 13 CR -1 05/26/24, 11:52

    i'd love to see a signed off by Benjamin on this. -1 to give him a chance for review.
  19. core-ci voted on patch set 13 V +1 05/26/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58275

  20. Christian Kuhn commented on patch set 13 CR 0 05/27/24, 08:27

    got a personal "like it" from benjamin, patch is free for casual review now.
  21. Stefan Bürk voted on patch set 13 CR +1 V +1 05/27/24, 12:14

  22. Benjamin Franzke commented on patch set 13 CR -1 05/27/24, 12:25

    looks good, will review in detail
  23. Benjamin Franzke commented on patch set 13 CR +2 V +2 05/27/24, 12:32

    Services.yaml:21

    This leads to a changed DI container (service is no longer public), but fine for a `main`-only patch, and the mentioned comment is obviously no longer true
  24. Benjamin Franzke merged patch set 14 05/27/24, 12:32

  25. Christian Kuhn commented on patch set 14 05/27/24, 12:35

    Services.yaml:21 Reply

    yes. i checked usages and left this particular one out. class is internal, should be fine.