84406[TASK] Use PHP attributes more often to configure DI
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 35
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+4 −0
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php+7 −5
- typo3/sysext/backend/Configuration/Services.yaml+0 −9
- typo3/sysext/core/Classes/Configuration/Extension/ExtLocalconfFactory.php+7 −3
- typo3/sysext/core/Classes/Configuration/Extension/ExtTablesFactory.php+7 −3
- typo3/sysext/core/Classes/Configuration/Tca/TcaFactory.php+8 −4
- typo3/sysext/core/Classes/DataHandling/SoftReference/SoftReferenceParserFactory.php+8 −13
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderConfigurationLoader.php+9 −4
- typo3/sysext/core/Classes/Page/ImportMapFactory.php+5 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+2 −1
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+8 −3
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+9 −5
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.php+9 −5
- typo3/sysext/core/Configuration/Services.yaml+4 −56
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+4 −2
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgets.yaml+0 −2
- typo3/sysext/dashboard/Documentation/Configuration/WidgetRegistration.rst+0 −2
- typo3/sysext/dashboard/Documentation/Developer/MakeRefreshable.rst+0 −1
- typo3/sysext/dashboard/Documentation/Widgets/RssWidget.rst+0 −6
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+5 −0
Show 15 more files
- typo3/sysext/extbase/Classes/Persistence/ClassesConfigurationFactory.php+9 −13
- typo3/sysext/extbase/Configuration/Services.yaml+0 −11
- typo3/sysext/form/Classes/Service/TranslationService.php+4 −0
- typo3/sysext/form/Configuration/Services.yaml+0 −5
- typo3/sysext/frontend/Classes/Cache/CacheLifetimeCalculator.php+4 −0
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php+8 −6
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+3 −0
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+4 −0
- typo3/sysext/frontend/Configuration/Services.yaml+0 −19
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+2 −0
- typo3/sysext/recycler/Configuration/Services.yaml+0 −4
- typo3/sysext/redirects/Classes/Service/RedirectService.php+2 −0
- typo3/sysext/redirects/Configuration/Services.yaml+0 −4
- typo3/sysext/webhooks/Classes/Repository/WebhookRepository.php+2 −0
- typo3/sysext/webhooks/Configuration/Services.yaml2+0 −5
Review log 2033
Show 48 earlier messages
-
Christian Kuhn uploaded patch set 1 05/26/24, 09:26
-
Christian Kuhn uploaded patch set 2 05/26/24, 09:33
-
Christian Kuhn uploaded patch set 3 05/26/24, 09:37
-
core-ci voted on patch set 2 V +1 05/26/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58260
-
core-ci voted on patch set 1 V -1 05/26/24, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58257
-
core-ci voted on patch set 3 V +1 05/26/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58261
-
Christian Kuhn uploaded patch set 4
V +105/26/24, 09:56 -
core-ci voted on patch set 4 V +1 05/26/24, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58262
-
Christian Kuhn uploaded patch set 5
V +105/26/24, 10:02 -
core-ci voted on patch set 5 V +1 05/26/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58263
-
Christian Kuhn uploaded patch set 6
V +105/26/24, 10:14 -
core-ci voted on patch set 6 V -1 05/26/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58264
-
Christian Kuhn uploaded patch set 7
V -105/26/24, 10:22 -
core-ci voted on patch set 7 V +1 05/26/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58265
-
Christian Kuhn uploaded patch set 8
V +105/26/24, 10:37 -
core-ci voted on patch set 8 V -1 05/26/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58267
-
Christian Kuhn uploaded patch set 9
V -105/26/24, 10:46 -
core-ci voted on patch set 9 V +1 05/26/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58268
-
Christian Kuhn uploaded patch set 10
V +105/26/24, 10:53 -
core-ci voted on patch set 10 V +1 05/26/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58269
-
Christian Kuhn uploaded patch set 11
V +105/26/24, 11:15 -
Christian Kuhn uploaded patch set 12 05/26/24, 11:19
-
core-ci voted on patch set 11 V +1 05/26/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58271
-
core-ci voted on patch set 12 V +1 05/26/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58272
-
Christian Kuhn uploaded patch set 13
V +105/26/24, 11:51 -
Christian Kuhn commented on patch set 13 CR -1 05/26/24, 11:52
i'd love to see a signed off by Benjamin on this. -1 to give him a chance for review. -
core-ci voted on patch set 13 V +1 05/26/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58275
-
Christian Kuhn commented on patch set 13 CR 0 05/27/24, 08:27
got a personal "like it" from benjamin, patch is free for casual review now. -
Stefan Bürk voted on patch set 13 CR +1 V +1 05/27/24, 12:14
-
Benjamin Franzke commented on patch set 13 CR -1 05/27/24, 12:25
looks good, will review in detail -
Benjamin Franzke commented on patch set 13 CR +2 V +2 05/27/24, 12:32
Services.yaml:21This leads to a changed DI container (service is no longer public), but fine for a `main`-only patch, and the mentioned comment is obviously no longer true -
Benjamin Franzke merged patch set 14 05/27/24, 12:32
-
Christian Kuhn commented on patch set 14 05/27/24, 12:35
Services.yaml:21Replyyes. i checked usages and left this particular one out. class is internal, should be fine.