Review 12.4 Merged

84445[BUGFIX] Return always an integer in ProcessedFile::getSize

Georg Ringer CR +2 V +2 Easy +2 −2 updated 07/24/24, 12:19

Commit message

ProcessedFile::getSize() can call AbstractFile::getSize which can return
null instead of integer which is required as return type. Add a type
cast to avoid exceptions.

Backport the changes done already in v13 with #101327.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1115

  1. Georg Ringer uploaded patch set 1 05/29/24, 20:57

  2. Georg Ringer commented on patch set 1 05/29/24, 20:58

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/29/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58452

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 05/29/24, 21:08

  5. Stefan Bürk voted on patch set 1 CR -1 05/31/24, 04:33

  6. Georg Ringer rebased onto patch set 2 CR +1 V +1 07/16/24, 12:25

  7. core-ci voted on patch set 2 V +1 07/16/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61631

  8. Georg Ringer uploaded patch set 3 V +1 07/23/24, 11:38

  9. core-ci voted on patch set 3 V +1 07/23/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62006

  10. Christian Kuhn updated the commit message in patch set 4 V +1 07/24/24, 11:09

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 07/24/24, 11:10

  12. Garvin Hicking voted on patch set 4 CR +1 V +1 07/24/24, 11:11

  13. core-ci voted on patch set 4 V +1 07/24/24, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62088

  14. Georg Ringer voted on patch set 4 CR +2 V +2 07/24/24, 12:19

  15. Georg Ringer merged patch set 5 07/24/24, 12:19