Review main Merged

84474[TASK] Use CPP in FileDumpController

Torben Hansen CR +2 V +2 Easy +6 −16 updated 06/03/24, 07:45

Commit message

With this change, CPP is used in FileDumpController.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Torben Hansen uploaded patch set 1 06/01/24, 12:50

  2. core-ci voted on patch set 1 V +1 06/01/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58566

  3. Oliver Klee commented on patch set 1 CR +1 V +1 06/01/24, 15:58

    Looks good to me! Could we simplify this and make the whole class `readonly` instead?
  4. Georg Ringer voted on patch set 1 CR +1 V +1 06/02/24, 20:47

  5. Benni Mack commented on patch set 2 CR +1 V +1 06/03/24, 06:04

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V +1 06/03/24, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58606

  7. Benni Mack commented on patch set 2 CR +1 V +1 06/03/24, 06:29

    Reply

    Done
  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/03/24, 07:45

  9. Stefan Bürk merged patch set 3 06/03/24, 07:45