Review main Merged

84478[BUGFIX] Ensure access check for module aliases

Thomas Hohn CR +2 V +2 Normal +70 −3 updated 06/07/24, 09:16

Commit message

This patch extends the access checks for modules. This is done
by checking both the module identifier and potential aliases.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1824

  1. Thomas Hohn uploaded patch set 1 06/03/24, 09:04

  2. core-ci voted on patch set 1 V +1 06/03/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58614

  3. Mathias Brodala updated the commit message in patch set 2 V +1 06/03/24, 09:28

  4. core-ci voted on patch set 2 V +1 06/03/24, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58615

  5. Mathias Brodala commented on patch set 2 CR -1 06/03/24, 09:40

    ModuleProvider.php:244

    IMO these two should be done together since they do the same. Changing one without the other has a risk of introducing security issues. On the other hand the "isAdmin" check here should be separate and directly return.
  6. Thomas Hohn uploaded patch set 3 CR -1 V +1 06/03/24, 10:33

  7. core-ci voted on patch set 3 V +1 06/03/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58616

  8. Thomas Hohn commented on patch set 3 06/03/24, 10:38

    ModuleProvider.php:244 Reply

    Done
  9. Mathias Brodala commented on patch set 4 V +1 06/03/24, 10:44

    Published edit on patch set 3.
  10. Mathias Brodala voted on patch set 4 CR +1 06/03/24, 10:45

  11. core-ci voted on patch set 4 V +1 06/03/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58618

  12. Garvin Hicking voted on patch set 4 CR +1 06/03/24, 12:54

  13. Georg Ringer voted on patch set 4 CR +1 V +1 06/03/24, 18:56

  14. Christian Kuhn commented on patch set 4 CR +1 06/05/24, 14:20

    +1 reading, but would love if Oli Bartsch could have a final look.
  15. Oli Bartsch commented on patch set 4 CR -1 06/05/24, 14:24

    Reply

    will have a look 👍
  16. Oli Bartsch uploaded patch set 5 CR +1 V +1 06/07/24, 08:24

  17. Oli Bartsch commented on patch set 5 CR +1 V +1 06/07/24, 08:29

    Reply

    Great patch. Added some tests.
  18. core-ci voted on patch set 5 V +1 06/07/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58860

  19. Thomas Hohn commented on patch set 5 06/07/24, 08:32

    Reply

    Thx ;-)
  20. Benni Mack commented on patch set 6 CR +1 V +1 06/07/24, 08:44

    Published edit on patch set 5.
  21. core-ci voted on patch set 6 V +1 06/07/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58862

  22. Georg Ringer voted on patch set 6 CR +1 V +1 06/07/24, 09:08

  23. Oli Bartsch voted on patch set 6 CR +2 V +2 06/07/24, 09:16

  24. Oli Bartsch merged patch set 7 06/07/24, 09:16