Review main Merged

84491[BUGFIX] Do not set original token value stream in TS AstBuilder

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 06/04/24, 16:21

Commit message

The 'original value token stream' is a helper used in
BE TypoScript modules to render a possible constant
substitution.
It is enough if the CommentAwareAstBuilder handles this,
which is used in those cases: getOriginalValueTokenStream()
is only called by fluid as 'child.originalValueTokenStream'
when rendering TS trees in the backend. Those use
CommentAwareAstBuilder and not "production" AstBuilder.
The patch avoids calling setOriginalValueTokenStream() as
a minor micro optimization which may also help the garbage
collection to clean up some objects more early in FE.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/04/24, 15:41

  2. Christian Kuhn updated the commit message in patch set 2 06/04/24, 15:45

  3. core-ci voted on patch set 1 V +1 06/04/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58684

  4. core-ci voted on patch set 2 V +1 06/04/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58685

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/04/24, 16:01

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/04/24, 16:09

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/04/24, 16:21

  8. Christian Kuhn merged patch set 3 06/04/24, 16:21