Review main Merged

84493[BUGFIX] Declare setFlatConstants() returns void

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 06/04/24, 16:39

Commit message

Add a missing return value in
ConstantAwareTokenStream->setFlatConstants().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/04/24, 16:31

  2. Stefan Bürk voted on patch set 1 CR +1 V +1 06/04/24, 16:33

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 06/04/24, 16:35

  4. core-ci voted on patch set 1 V +1 06/04/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58689

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 06/04/24, 16:39

  6. Christian Kuhn merged patch set 2 06/04/24, 16:39